Migrate to Material 3 #333
Conversation
kul3r4
commented
Jun 23, 2025
kul3r4
commented
- Migrate to Material 3
- Lot of space/formats fixes as this repository after running spotless
- Added some missing copyrights
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kul3r4, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on modernizing the ExerciseSampleCompose application by migrating its UI to Wear Compose Material 3. This comprehensive update is complemented by significant upgrades to the project's build system and dependencies, the introduction of automated code formatting, and the addition of missing copyright headers, all contributing to a more consistent, maintainable, and up-to-date codebase.
Highlights
- Material 3 Migration: The application has been extensively migrated to use Wear Compose Material 3 components and theming. This includes updates to
MaterialTheme,AppScaffold, various button types (Button,FilledIconButton,CompactButton),Slider,SwitchButton,ConfirmationDialog,AlertDialog,Icon, andTextcomponents, aligning the UI with the latest Material Design guidelines. - Build System and Dependency Updates: Significant updates have been applied to the build system, including upgrading the Android Gradle Plugin, Kotlin, and various Compose, Wear Compose, Dagger, Health Services, and Horologist library versions. A key change is the migration of Dagger Hilt's annotation processing from Kapt to KSP.
- Code Formatting and Style Enforcement: A new
.editorconfigfile has been added to define consistent code style rules, such as indentation, line endings, and line length. Furthermore, the Spotless Gradle plugin has been integrated across subprojects to automatically enforce these formatting rules, leading to numerous minor formatting and spacing fixes throughout the codebase. - Copyright Headers: Missing Apache 2.0 copyright headers have been added to several source files, ensuring proper licensing and consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| @@ -120,7 +121,7 @@ dependencies { | |||
| // Hilt | |||
| implementation libs.hilt.navigation.compose | |||
| implementation libs.dagger.hilt.android | |||
There was a problem hiding this comment.
Consider using alias instead of implementation for dependency declarations to take advantage of type-safe dependency accessors.
// Hilt
implementation(libs.hilt.navigation.compose)
implementation(libs.dagger.hilt.android)
ksp(libs.hilt.compiler)
.../main/java/com/example/exercisesamplecompose/presentation/dialogs/ExerciseInProgressAlert.kt
Show resolved
Hide resolved
|
Realized I am missing |
.../app/src/main/java/com/example/exercisesamplecompose/presentation/dialogs/ExerciseGoalMet.kt
Outdated
Show resolved
Hide resolved
.../app/src/main/java/com/example/exercisesamplecompose/presentation/exercise/ExerciseScreen.kt
Outdated
Show resolved
Hide resolved
...ain/java/com/example/exercisesamplecompose/presentation/preparing/PreparingExerciseScreen.kt
Outdated
Show resolved
Hide resolved
...ampleCompose/app/src/main/java/com/example/exercisesamplecompose/presentation/theme/Theme.kt
Show resolved
Hide resolved
...xerciseSampleCompose/app/src/test/screenshots/PreparingExerciseScreenTest_ticwatch_pro_5.png
Outdated
Show resolved
Hide resolved
...es/ExerciseSampleCompose/app/src/test/screenshots/ExerciseGoalsScreenTest_ticwatch_pro_5.png
Outdated
Show resolved
Hide resolved
| @@ -146,15 +147,18 @@ fun PreparingExerciseScreen( | |||
| .ambientGray(ambientState) | |||
| ) { | |||
| ScreenScaffold( | |||
| scrollState = if (ambientState.isInteractive) columnState else null, | |||
| timeText = {}) { | |||
| scrollState = columnState, | |||
There was a problem hiding this comment.
@ithinkihaveacat did you worked on adding the ambientState here? Scrollstate cannot be null for Material3, do we need this for ambient?
kul3r4
force-pushed
the
main
branch
2 times, most recently
from
ae2c63c to
0a3124a
Compare
