Skip to content

Conversation

@Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Jan 17, 2026

What I have done and why

package name doesn't represent module's package.

image

It should be
com.google.samples.apps.nowinandroid.core.common.

Change-Id: I3a9a603a9f3a76fa413d8074d9ccc873af0ddfdb
Change-Id: I16a81bf6e0383f838ec71364cca77b399915d079
@Jaehwa-Noh Jaehwa-Noh requested a review from dturner as a code owner January 17, 2026 03:48
@gemini-code-assist
Copy link

Summary of Changes

Hello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the package structure within the core module by moving network and result related classes under a new common subpackage. This change results in core.common.network and core.common.result packages, aiming to improve the logical organization and representation of the module's contents, ensuring package names accurately reflect their respective modules.

Highlights

  • Package Renaming: The core.network package has been renamed to core.common.network across multiple files to better reflect its module structure.
  • Import Updates: All corresponding import statements referencing the old core.network package have been updated to the new core.common.network path.
  • Result Package Refactoring: The core.result package has been renamed to core.common.result, with associated import updates in relevant files.
  • Copyright Year Adjustments: Copyright years in CoroutineScopesModule.kt and DispatchersModule.kt were updated from 2023/2022 to 2026.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors package names for better organization by moving core.network and core.result into the core.common module. The changes are consistently applied across most of the codebase. I've found one instance where a test file's package was not updated to match the refactoring. My review includes a comment to address this to ensure the refactoring is complete and consistent.

Change-Id: I2a6b8bc30083d1559d533d024a9c537d43f8b667
@Jaehwa-Noh
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors several packages to better align with their module structure. Specifically, utilities related to networking and results within the core/common module have been moved to core.common.network and core.common.result packages respectively. All corresponding imports across the codebase have been updated. The changes improve code organization and consistency. The refactoring has been applied correctly and I have no further suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant