-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Rename package properly #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rename package properly #2045
Conversation
Change-Id: I3a9a603a9f3a76fa413d8074d9ccc873af0ddfdb
Change-Id: I16a81bf6e0383f838ec71364cca77b399915d079
Summary of ChangesHello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the package structure within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors package names for better organization by moving core.network and core.result into the core.common module. The changes are consistently applied across most of the codebase. I've found one instance where a test file's package was not updated to match the refactoring. My review includes a comment to address this to ensure the refactoring is complete and consistent.
core/common/src/test/kotlin/com/google/samples/apps/nowinandroid/core/result/ResultKtTest.kt
Outdated
Show resolved
Hide resolved
.../kotlin/com/google/samples/apps/nowinandroid/core/common/network/di/CoroutineScopesModule.kt
Show resolved
Hide resolved
...main/kotlin/com/google/samples/apps/nowinandroid/core/common/network/di/DispatchersModule.kt
Show resolved
Hide resolved
Change-Id: I2a6b8bc30083d1559d533d024a9c537d43f8b667
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly refactors several packages to better align with their module structure. Specifically, utilities related to networking and results within the core/common module have been moved to core.common.network and core.common.result packages respectively. All corresponding imports across the codebase have been updated. The changes improve code organization and consistency. The refactoring has been applied correctly and I have no further suggestions.
What I have done and why
package name doesn't represent module's package.
It should be
com.google.samples.apps.nowinandroid.core.common.