Fix incorrect loading test tag in BookmarksScreen

[amEya911]

What I have done and why

• Fixed a copy-paste error in BookmarksScreen.kt where the LoadingState composable had the wrong test tag "forYou:loading" instead of "bookmarks:loading"

All other test tags in the file correctly use the bookmarks: prefix (bookmarks:feed, bookmarks:empty), making this an obvious oversight from when the code was copied from the ForYou screen.

Fixes #2086

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important bug by rectifying a mislabeled test tag within the Bookmarks feature. The change ensures that the loading state in the BookmarksScreen is correctly identified during UI testing, aligning with the established naming conventions for the feature.

Highlights

• Test Tag Correction: Corrected an incorrect test tag from "forYou:loading" to "bookmarks:loading" in BookmarksScreen.kt to ensure consistency with other test tags in the Bookmarks feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• feature/bookmarks/impl/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/bookmarks/impl/BookmarksScreen.kt
  • Fixed an incorrect test tag for the LoadingState composable.

Activity

• No specific activity (comments, reviews, progress) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a copy-paste error by correcting the test tag for the loading state in BookmarksScreen.kt from "forYou:loading" to "bookmarks:loading". This change ensures consistency with other test tags within the bookmarks feature. The fix is accurate and well-contained. I have no further suggestions.

[dturner]

Fixed in #2089