-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to AGP 8.1.1, kotlin 1.8.20, and robolectric 4.10.3 #485
Conversation
Use AGP Upgrade Assistant to upgrade all projects to AGP 8.1.0 and follow recommendations on deprecated attributes, including: - rename compileSdkVersion to compileSdk - remove buildToolsVersion as its now bundled with AGP
This was necessary to get the tests working on a Mac with JDK 19.
@@ -53,6 +51,7 @@ android { | |||
kotlinOptions { | |||
jvmTarget = '1.8' | |||
} | |||
namespace 'com.example.android.testing.espresso.fragmentscenario' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we determining if the build.gradle
files need a testNamespace
and to not abort on lint failure?
Do we need to add a testNamespace
+ abortOnError
here for consistency?
Also, this is a nitpick but the rest of the namespaces are capitalized, e.g. FragmentScenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comment but this is all historical. This PR is already large and I'd like to keep it focused just on the upgrade. These entries were all auto generated by Studio update wizard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest unifying the single quotes (added by the new change) vs double quotes (used by existing build file).
These build files are unfortunately already inconsistent - using a mixture of quotes. I'll put up a PR that corrects it globally. |
This is needed to support running on JDK 20. By mistake this change was somehow not included in PR #485
No description provided.