Skip to content

Don't treat + as a special character for queries #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't treat + as a special character for queries #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a09f0b
Don't treat + as a special character for queries
kellyma2 Aug 12, 2025
ebf0216
Fix up comment referencing `+` re-writing
kellyma2 Nov 20, 2025
e5ff513
Merge branch 'master' into special-query
kellyma2 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func ExampleChangesService_QueryChanges_withSymbols() {

opt := &gerrit.QueryChangeOptions{}
opt.Query = []string{
"change:249244+status:merged",
"change:249244 status:merged",
}
opt.Limit = 2
opt.AdditionalFields = []string{"LABELS"}
Expand Down
9 changes: 4 additions & 5 deletions gerrit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,6 @@ func CheckResponse(r *http.Response) error {
// Gerrit. Note, Gerrit itself does not escape these values when using the
// search box so we shouldn't escape them either.
var queryParameterReplacements = map[string]string{
"+": "GOGERRIT_URL_PLACEHOLDER_PLUS",
":": "GOGERRIT_URL_PLACEHOLDER_COLON"}

// addOptions adds the parameters in opt as URL query parameters to s.
Expand All @@ -528,10 +527,10 @@ func addOptions(s string, opt interface{}) (string, error) {

// If the url contained one or more query parameters (q) then we need
// to do some escaping on these values before Encode() is called. By
// doing so we're ensuring that : and + don't get encoded which means
// they'll be passed along to Gerrit as raw ascii. Without this Gerrit
// could return 400 Bad Request depending on the query parameters. For
// more complete information see this issue on GitHub:
// doing so we're ensuring that : doesn't get encoded which means it'll
// be passed along to Gerrit as raw ascii. Without this Gerrit could
// return 400 Bad Request depending on the query parameters. For more
// complete information see this issue on GitHub:
// https://github.com/andygrunwald/go-gerrit/issues/18
_, hasQuery := qs["q"]
if hasQuery {
Expand Down