Fix paging-related bugs by reworking the strategy

[sveniu]

Responses from the S3 ListObjectVersions API may have pages where the Versions list is not present because the DeleteMarkers list takes up the entire page.

Fix that bug and rework the strategy to make it clearer and easier to reason about.

[angeloc]

@sveniu Any news on this? It looks promising!

[sveniu]

@angeloc It ended up being hard to test, so I worked on getmoto/moto#6896 for a while to be able to use moto in the s3-pit-restore tests. I'm not actually 100% certain that the moto change implements the exact behaviour of the real S3 server, but it should be pretty close and quite useful for testing.

Timing wise, this has fallen off my radar for the moment, but it is still relevant to me and I'll likely come back to work on this soon-ish.

[angeloc]

@angeloc It ended up being hard to test, so I worked on getmoto/moto#6896 for a while to be able to use moto in the s3-pit-restore tests

Very nice indeed!

Timing wise, this has fallen off my radar for the moment, but it is still relevant to me and I'll likely come back to work on this soon-ish.

No problem, you do it when you can, like the rest of us!