Skip to content

fix(material/expansion): all panels appearing open when printing #32602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crisbeto wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −10
Open

fix(material/expansion): all panels appearing open when printing #32602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions src/material/expansion/expansion-panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

@use '@angular/cdk';
@use './m3-expansion';
@use '../core/tokens/token-utils';
Expand All @@ -14,8 +13,9 @@ $fallbacks: m3-expansion.get-tokens();
overflow: hidden;

&.mat-expansion-panel-animations-enabled {
transition: margin 225ms variables.$fast-out-slow-in-timing-function,
elevation.private-transition-property-value();
transition:
margin 225ms variables.$fast-out-slow-in-timing-function,
elevation.private-transition-property-value();
}

// Required so that the `box-shadow` works after the
Expand All @@ -31,7 +31,8 @@ $fallbacks: m3-expansion.get-tokens();
}

.mat-accordion & {
&:not(.mat-expanded), &:not(.mat-expansion-panel-spacing) {
&:not(.mat-expanded),
&:not(.mat-expansion-panel-spacing) {
border-radius: 0;
}

Expand All @@ -51,6 +52,15 @@ $fallbacks: m3-expansion.get-tokens();
}
}

// Styles to use if grid isn't supported for some reason.
@mixin _fallback-styles {
height: 0;

.mat-expansion-panel.mat-expanded > & {
height: auto;
}
}

.mat-expansion-panel-content-wrapper {
// Note: we can't use `overflow: hidden` here, because it can clip content with
// ripples or box shadows. Instead we transition the `visibility` below.
Expand All @@ -72,13 +82,14 @@ $fallbacks: m3-expansion.get-tokens();
// we have a fallback to `height` which doesn't animate, just in case.
// stylelint-disable material/no-prefixes
@supports not (grid-template-rows: 0fr) {
height: 0;

.mat-expansion-panel.mat-expanded > & {
height: auto;
}
@include _fallback-styles;
}
// stylelint-enable material/no-prefixes

// Use the fallback styles when printing, otherwise closed panel appear open (see #32327).
@media print {
@include _fallback-styles;
}
}

.mat-expansion-panel-content {
Expand Down Expand Up @@ -137,7 +148,8 @@ $fallbacks: m3-expansion.get-tokens();

border-top-color: token-utils.slot(expansion-actions-divider-color, $fallbacks);

.mat-button-base, .mat-mdc-button-base {
.mat-button-base,
.mat-mdc-button-base {
margin-left: 8px;

[dir='rtl'] & {
Expand Down
Loading