Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(panel): use existing _md-panel-offscreen class instead of inline styles #11942

Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix(panel): use existing _md-panel-offscreen class instead of inline styles #11942

merged 1 commit into from
Jun 18, 2020

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
Fixes #11941

What is the new behavior?

  • use existing _md-panel-offscreen class instead of inline styles
  • fix some invalid or inaccurate types, JSDoc, and comments
  • improve type safety and IDE support by using @types/angular more
  • fix broken link to setNonce() docs in Theming Intro
  • improve setNonce() documentation
  • fix dgeni complaining about dangling links
  • fix typos

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar
fix(panel): use existing _md-panel-offscreen class instead of inline …
609014f 
…styles

- fix broken link to `setNonce()` docs in Theming Intro
- improve `setNonce()` documentation
- fix some invalid or inaccurate types, JSDoc, and comments
- improve type safety and IDE support by using `@types/angular` more
- fix dgeni complaining about dangling links
- fix typos

Fixes #11941
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 18, 2020
@Splaktar Splaktar self-assigned this Jun 18, 2020
@Splaktar Splaktar requested a review from mmalerba June 18, 2020 05:20
@Splaktar Splaktar added this to the 1.1.23 milestone Jun 18, 2020
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. type: bug severity: regression This issue is related to a regression pr: merge ready This PR is ready for a caretaker to review labels Jun 18, 2020
@oliversalzburg
Copy link
Contributor

I can only verifiy this when I have some published package that I can consume in our build pipeline :(

mmalerba
mmalerba approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar merged commit 000a023 into master Jun 18, 2020
@Splaktar Splaktar deleted the panel-remove-inline-styles branch June 18, 2020 18:51
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Jun 18, 2020
@Splaktar Splaktar mentioned this pull request Jun 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Milestone
1.1.23
Development

Successfully merging this pull request may close these issues.

panel: new unsafe-inline styles
4 participants
@Splaktar @oliversalzburg @mmalerba @googlebot