Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(panel): resolve animation issues #11947

Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix(panel): resolve animation issues #11947

merged 2 commits into from
Jun 23, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jun 22, 2020

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  1. panels that animate in aren't shown on screen
  2. panels that are reused, accumulate transforms causing strange, compounding issues

Issue Number:
FIxes #11946

What is the new behavior?

  1. remove md-panel-offscreen from innerWrapper in _updatePosition() if init is true
  2. remove the inline transforms after the close animation runs so that reused panels don't accumulate transforms

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I'll merge this to master and then cherry pick it to the 1.1.x branch.

Splaktar added 2 commits June 22, 2020 18:04
- this resulted in animated in panels not displaying on screen

Fixes #11946
- so that re-used panels don't accumulate transforms
- improve type safety and JSDoc comments
- remove unused variable and adjust code styles

Fixes #11946
@Splaktar Splaktar added this to the 1.1.24 milestone Jun 22, 2020
@Splaktar Splaktar self-assigned this Jun 22, 2020
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jun 22, 2020
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug labels Jun 22, 2020
@Splaktar Splaktar requested a review from mmalerba June 22, 2020 22:12
@Splaktar
Copy link
Contributor Author

@oliversalzburg PTAL

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliversalzburg
Copy link
Contributor

It looks pretty good to me, although I'm again unable to easily test this 😭 Given that the transform is now removed, I have high hopes for this change. I suspected code to achieve that existed previously and was simply not triggered for some reason. If we can get this merged, I'll test a build from the bower repo ASAP.

@Splaktar Splaktar merged commit 6322e98 into master Jun 23, 2020
@Splaktar Splaktar deleted the panel-fix-animations branch June 23, 2020 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel: sometimes doesn't appear in 1.1.23
4 participants