This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(panel): allow transform to be animated on an offset panel #9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
9905/panel-offset-animation
branch
from
fc21fb0 to
01ef22a
Compare
bradrich
suggested changes
Oct 31, 2016
src/components/panel/panel.js
Outdated
| @@ -2605,37 +2619,37 @@ MdPanelPosition.prototype.getTransform = function() { | |||
|
|
|||
| /** | |||
| * Sets the `transform` value for a panel element. | |||
| * @param {!angular.JQLite} panelEl | |||
| * @param {!angular.JQLite} element | |||
There was a problem hiding this comment.
For consistency sake, I would just use el here, and then all the way through.
crisbeto
force-pushed
the
9905/panel-offset-animation
branch
from
01ef22a to
098f8df
Compare
bradrich
approved these changes
Oct 31, 2016
|
@crisbeto - please rebase and I will do a final review. |
ThomasBurleson
added
the
needs: rebase
crisbeto
force-pushed
the
9905/panel-offset-animation
branch
from
098f8df to
c9f01b7
Compare
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
9905/panel-offset-animation
branch
from
c9f01b7 to
ae4bdca
Compare
|
Done @ThomasBurleson. |
crisbeto
removed
the
needs: rebase
Splaktar
added
ui: CSS
hotlist: animations
ux: polish
needs: rebase
|
Please rebase once more. |
Previously, if a panel had a position with an offset (e.g. `$mdPanel.newPanelPosition().center()`), the positioning would break any `transform` animations on the panel. This was due to the fact that `mdPanel` uses inline `transform` styles to do the offsetting. These changes introduce a wrapper around the panel (`.md-panel-inner-wrapper`), which will handle all of the positioning, allowing for any animations to be applied to the `.md-panel` itself. Relates to angular#9641. Fixes angular#9905.
crisbeto
force-pushed
the
9905/panel-offset-animation
branch
from
ce1f5c9 to
9cad06e
Compare
|
Rebased. |
Splaktar
removed
the
needs: rebase
Splaktar
added
P2: required
Splaktar
changed the title
6 tasks
|
I'm going to move this over to #11390 since it needs rebasing again and will also need some changes to fix tooltip styling. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a panel had a position with an offset (e.g.
$mdPanel.newPanelPosition().center()), the positioning would break anytransformanimations on the panel. This was due to the fact thatmdPaneluses inlinetransformstyles to do the offsetting. These changes introduce a wrapper around the panel (.md-panel-inner-wrapper), which will handle all of the positioning, allowing for any animations to be applied to the.md-panelitself.Relates to #9641.
Fixes #9905.