You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i'm adding test-renderer-rosling-bubbles.R to verify interactive bubble plots.
local Verification:
my previous test video didn't utilize the internal Chromote functions. I have now refactored the environment to use a Chromote backend, allowing for a post-JS rendered DOM capture.
updated Video Demo: [https://youtu.be/F5YkaAXtUbo]
@suhaani-agarwal, @tdhock please review the test logic. I have also patched the tests_init() helpers locally to support this Chromote workflow; let me know if those should be included here or in a separate PR.
the test looks good and aligns with the GSoC evaluation requirements.
From my understanding, similar svg-rendering checks already exist in other test-renderer-* files, so this may not add new coverage, but it does show a clear understanding of the animint2 testing workflow.
If you’d like to explore further, you could try extending the test to validate interactive behaviours (e.g., tooltips, clickSelects, or dynamic year transitions).
i’ve updated the test to use the new parameter-based syntax for showSelected and clickSelects. i also extended it to validate interactive elements like the Play/Pause widgets and selection attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm adding test-renderer-rosling-bubbles.R to verify interactive bubble plots.
local Verification:
my previous test video didn't utilize the internal Chromote functions. I have now refactored the environment to use a Chromote backend, allowing for a post-JS rendered DOM capture.
updated Video Demo: [https://youtu.be/F5YkaAXtUbo]
@suhaani-agarwal, @tdhock please review the test logic. I have also patched the tests_init() helpers locally to support this Chromote workflow; let me know if those should be included here or in a separate PR.