Wallet sdk credential and proof plus display #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
force-pushed
the
wallet-sdk
branch
from
45a5915 to
50ba434
Compare
berendsliedrecht
force-pushed
the
wallet-sdk-credential-and-proof-plus-display
branch
from
926e723 to
afa7abd
Compare
berendsliedrecht
force-pushed
the
wallet-sdk
branch
from
50ba434 to
f7bf413
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
wallet-sdk-credential-and-proof-plus-display
branch
from
72e9c00 to
7846041
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
wallet-sdk-credential-and-proof-plus-display
branch
2 times, most recently
from
54e7d87 to
c586b15
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
wallet-sdk-credential-and-proof-plus-display
branch
from
c586b15 to
838a29d
Compare
TimoGlastra
reviewed
Jul 16, 2025
TimoGlastra
reviewed
Jul 16, 2025
TimoGlastra
reviewed
Jul 16, 2025
TimoGlastra
reviewed
Jul 16, 2025
TimoGlastra
reviewed
Jul 16, 2025
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
TimoGlastra
reviewed
Jul 17, 2025
TimoGlastra
reviewed
Jul 17, 2025
TimoGlastra
reviewed
Jul 17, 2025
Comment on lines
+13
to
+14
| // TODO: remove this? | ||
| credentialCategory?: CredentialCategoryMetadata['credentialCategory'] |
There was a problem hiding this comment.
Why remove it? I think we're using this to retrieve the PID record
There was a problem hiding this comment.
Yeah mainly because we only really use it for the PID. Just wondering about how relevant that is in a general SDK.
TimoGlastra
reviewed
Jul 17, 2025
| @@ -0,0 +1,10 @@ | |||
| import { useCredentialRecords } from './useCredentialRecords' | |||
|
|
|||
| export const useCredentialRecordById = (id: string) => { | |||
There was a problem hiding this comment.
I think for all these hooks we need to update it to use the for display variant by default (which also includes the record i think?)
There was a problem hiding this comment.
the useCredentials now returns display information, and the useCredentialRecords only the record. useCredentials will be a public hook and useCredentialRecords will be an internal hook
TimoGlastra
reviewed
Jul 17, 2025
TimoGlastra
reviewed
Jul 17, 2025
TimoGlastra
reviewed
Jul 17, 2025
TimoGlastra
approved these changes
Jul 17, 2025
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
deleted the
wallet-sdk-credential-and-proof-plus-display
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential and proof display
I have migrated quite some functionality from
@packages/agentto@paradym/wallet-sdk. This mainly includes the display functionality for credentials and proofs. It also includes a lot of hooks, invitation functionality and utils. Theeasypidapp now uses some of this new functionality from the wallet sdk, but it has to be refactored to use theParadymWalletSdkinstance, so the usage is not too relevant. I mainly changed it so that migrating to usage of theParadymWalletSdkis easier, as all the types already line up.I also used
Errorinternally, as all cases that were reached were fatal. At a higher level,ParadymWalletSdk, we can wrap this and convert into an object with asuccessor something equivalent.Git also did not correctly remap some files, even when using
git mvsadly.There are still some tasks related to this, like improving the DX of the proof display attributes, but I would like to do this in a new PR as +3.3k and -2.6k is a bit much.