Closed
Conversation
Owner
|
Hey @joshmenden, thanks for the PR. I don't want to change the formatting or add linting, but it seems like |
joshmenden
force-pushed
the
joshmenden/standardrb
branch
from
feba804 to
5506ceb
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was poking around the repo and thought it might be nice to enforce some code formatting rules for consistency.
I figured standardrb would be a pretty safe place to put something in place without needing to decide on an individual rule configuration. The repo was pretty well compliant, mostly just the
respond_to_missing?method thatstandardrbrequires was added as net new code.Also added a Github Action to check that everything is formatted correctly.
LMK if you have strong feelings against this, or if you'd rather take a different approach. Happy to close the PR or revamp it if you have strong opinions!