-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): required ubuntu 24 runner forward ports as 24
is now latest
#422
base: main
Are you sure you want to change the base?
Conversation
that should allow enough space to run without liberating disk manually
Confirmed expected ubuntu-24 runner image:
But xz-utils was apparently already installed, at the correct version 🤔
So I expect this to fail again with |
af8a445
to
99b2782
Compare
Definitely installed something new at least, when using
|
We've possibly hardcoded a path?
|
I'm still working through this. The emulator runner isn't working with ubuntu-latest == ubuntu24 yet, there is an issue upstream There was also this nugget in the log which I'm working through:
Got a few things local but I'm working on this in parallel with a few other things for other repos so it'll be stop starty but I'm on it |
79d9c14
to
00d4079
Compare
minSdk 23 now compileSdk / targetSdk 35 now
00d4079
to
0ead6af
Compare
I may have a local fix for the upstream issue but I need to close/reopen so that my fork of the action is on the allowed list |
0ead6af
to
efc32cc
Compare
ubuntu-latest == 24 means that command line tools have been updated a bit, enough to have a "latest" symlink in place on the image, but not enough to be actually current also a recent change in the upstream runner isn't safe enough with the way it chowns files finally, ubuntu-24 wants more AVD-related env vars set for things to work correctly I have forked the upstream action and fixed these things but they won't merge for a while
07ff05b
to
b0ba980
Compare
upstream issue on emulator runner will likely resolve soon, but now I've got rsdroid.so not found when running the emulator test @david-allison does this look familiar to you at all?
I don't have an Ubuntu 24 env laying around at the moment to check myself, but I worry that similar to liblzma not being on the system, this could be a subtle linkage issue. Or it could just be some obvious failure that the build system silently glosses over - there doesn't seem to be a lot of "did the expected products from this stage actually get produced correctly?" type verification as the build works |
Do we have the Not enough information from that error to know where the issue came from |
No, the workflow would need some hackery to post it as an artifact or similar, which would require finding out exactly where it is, at which point it's probably faster to spin up an ubuntu 24 vm locally but I won't have time for that for a while unfortunately |
Oh! I see that you actually do upload those artifacts, you must have set that up long ago, I see it on another run https://github.com/ankidroid/Anki-Android-Backend/actions/runs/11297029758?pr=423 so perhaps we have the .so This isn't the highest priority (I pinned the runner to ubuntu-22 today on main) so will catch this as I can, or feel free anyone else reading this... |
a package with stable name that will always depend on it (xz-utils)the liblzma-dev package which should provide itThe need for this was noticed when a simple dependabot PR failed:
https://github.com/ankidroid/Anki-Android-Backend/actions/runs/11278308705/job/31366466007?pr=421#step:13:40
...which led to a quick look at the runner image in use, noticed it was ubuntu-24 now and saw it just rolled out https://github.com/actions/runner-images/blob/ubuntu24/20241006.1/images/ubuntu/Ubuntu2404-Readme.md
Success criteria for merge is that the Ubuntu runner goes green in CI with runner image 24