Issue#414 Fix Location header behind HTTPS proxy #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmirnov-dermview
commented
Oct 31, 2022
psmirnov-dermview
commented
- Server.php behind HTTPS reverse proxy
- Stop assuming the FQDN in Location header in responses
- Rely upon ApiPath configuration instead
- Responds with relative URLs by default
Owner
|
@psmirnov-dermview Thank you for working on this. Could you please fix the tests? |
jfstenuit
reviewed
Apr 13, 2023
jfstenuit
left a comment
jfstenuit
left a comment
There was a problem hiding this comment.
I was able to reproduce the issue and I can confirm this patch addresses it in my set-up.
- Server.php behind HTTPS reverse proxy - Stop assuming the FQDN in Location header in responses - Rely upon ApiPath configuration instead - Responds with relative URLs by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.