Skip to content

Conversation

@pataar
Copy link

@pataar pataar commented Feb 27, 2025

Fixes the Explicit nullable param type deprecation warnings and upgrades the test suite to include PHP 8.4.

@pataar
Copy link
Author

pataar commented Mar 28, 2025

@ankitpokhrel Friendly ping :)

@genintho
Copy link

@ankitpokhrel friendly ping

@demmmmios
Copy link

@ankitpokhrel please 🙌

@LukasVaculcik
Copy link

This would be really nice <3

@ankitpokhrel ankitpokhrel requested a review from Copilot November 7, 2025 16:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for PHP 8.4 by fixing deprecated nullable parameter type declarations. In PHP 8.4, using string $param = null is deprecated in favor of the explicit nullable syntax ?string $param = null. The PR updates all affected method signatures across the codebase and extends CI testing to include PHP 8.4.

Key Changes:

  • Updated method signatures to use explicit nullable type syntax (?string instead of string = null)
  • Extended GitHub Actions CI matrix to test against PHP 8.4
  • Updated code coverage reporting to use PHP 8.4 as the reference version

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Tus/Client.php Updated file() method signature to use explicit nullable type for $name parameter
src/Response.php Updated download() method signature to use explicit nullable type for $name parameter
src/File.php Updated __construct() and setMeta() method signatures to use explicit nullable types
src/Config.php Updated get() method signature to use explicit nullable type for $key parameter
src/Cache/FileStore.php Updated __construct() and lock() method signatures to use explicit nullable types
.github/workflows/ci.yml Added PHP 8.4 to test matrix and updated coverage reporting condition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (d431916) to head (340fc45).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #452      +/-   ##
============================================
- Coverage     99.60%   99.60%   -0.01%     
  Complexity      362      362              
============================================
  Files            20       20              
  Lines          1016     1007       -9     
============================================
- Hits           1012     1003       -9     
  Misses            4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants