-
-
Notifications
You must be signed in to change notification settings - Fork 215
Add support for PHP 8.4 #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@ankitpokhrel Friendly ping :) |
|
@ankitpokhrel friendly ping |
|
@ankitpokhrel please 🙌 |
|
This would be really nice <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for PHP 8.4 by fixing deprecated nullable parameter type declarations. In PHP 8.4, using string $param = null is deprecated in favor of the explicit nullable syntax ?string $param = null. The PR updates all affected method signatures across the codebase and extends CI testing to include PHP 8.4.
Key Changes:
- Updated method signatures to use explicit nullable type syntax (
?stringinstead ofstring = null) - Extended GitHub Actions CI matrix to test against PHP 8.4
- Updated code coverage reporting to use PHP 8.4 as the reference version
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tus/Client.php | Updated file() method signature to use explicit nullable type for $name parameter |
| src/Response.php | Updated download() method signature to use explicit nullable type for $name parameter |
| src/File.php | Updated __construct() and setMeta() method signatures to use explicit nullable types |
| src/Config.php | Updated get() method signature to use explicit nullable type for $key parameter |
| src/Cache/FileStore.php | Updated __construct() and lock() method signatures to use explicit nullable types |
| .github/workflows/ci.yml | Added PHP 8.4 to test matrix and updated coverage reporting condition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
============================================
- Coverage 99.60% 99.60% -0.01%
Complexity 362 362
============================================
Files 20 20
Lines 1016 1007 -9
============================================
- Hits 1012 1003 -9
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes the Explicit nullable param type deprecation warnings and upgrades the test suite to include PHP 8.4.