Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add berber language #66

Closed
wants to merge 1 commit into from
Closed

Add berber language #66

wants to merge 1 commit into from

Conversation

ihoudjedje
Copy link

@ihoudjedje ihoudjedje requested a review from dmythro as a code owner May 10, 2020 14:50
@dmythro
Copy link
Member

dmythro commented May 10, 2020

Thanks! As I see, the language is just spoken, but not official for specified countries.
Spoken languages features is planned in v3, which hopefully will come up soon. Until then I think it's better to hold this PR.

@ihoudjedje
Copy link
Author

Welcome, alright, let's hold that for a bit 👍

@dmythro dmythro linked an issue Mar 10, 2021 that may be closed by this pull request
Add spoken languages in addition to official #51
Open
@dmythro
Copy link
Member

dmythro commented Mar 22, 2021 •
edited
Loading

Hi @ihoudjedje. Didn't find any mentions for bb language code for ISO 639-1 alpha-2. Please send me a link if it is.

Moving into v3 (#83), there will finally be a room for spoken languages, so if it a valid one let's have it too.

@dmythro dmythro closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmythro dmythro Awaiting requested review from dmythro

Assignees
No one assigned
Labels
next spoken update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add spoken languages in addition to official
2 participants
@ihoudjedje @dmythro