update note encryption #392
ci.yml
on: push
Bitrot check
4m 15s
Lint
3m 37s
Nightly lint
17s
Intra-doc links
3m 47s
Rustfmt
18s
Security - Cargo Audit
5m 36s
Matrix: build
Matrix: test
Annotations
29 errors and 2 warnings
Nightly lint
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
Rustfmt
Process completed with exit code 1.
|
using `clone` on type `sapling::Note` which implements the `Copy` trait:
masp_primitives/src/transaction/components/sapling/builder.rs#L170
error: using `clone` on type `sapling::Note` which implements the `Copy` trait
--> masp_primitives/src/transaction/components/sapling/builder.rs:170:64
|
170 | let encryptor = sapling_note_encryption::<P>(self.ovk, self.note.clone(), self.memo);
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.note`
|
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
you are deriving `PartialEq` and can implement `Eq`:
masp_primitives/src/transaction/components/sapling/builder.rs#L69
error: you are deriving `PartialEq` and can implement `Eq`
--> masp_primitives/src/transaction/components/sapling/builder.rs:69:24
|
69 | #[derive(Debug, Clone, PartialEq)]
| ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
|
useless conversion to the same type: `u64`:
masp_primitives/src/transaction/builder.rs#L257
error: useless conversion to the same type: `u64`
--> masp_primitives/src/transaction/builder.rs:257:81
|
257 | .add_output(&mut self.rng, ovk, to, asset_type, NoteValue::from_raw(value.into()), memo)
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `sapling::NoteValue`:
masp_primitives/src/sapling.rs#L871
error: useless conversion to the same type: `sapling::NoteValue`
--> masp_primitives/src/sapling.rs:871:24
|
871 | value: value.into(),
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `u64`:
masp_primitives/src/sapling/note_encryption.rs#L644
error: useless conversion to the same type: `u64`
--> masp_primitives/src/sapling/note_encryption.rs:644:47
|
644 | let note = pa.create_note(asset_type, value.into(), rseed);
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `u64`:
masp_primitives/src/sapling/note_encryption.rs#L146
error: useless conversion to the same type: `u64`
--> masp_primitives/src/sapling/note_encryption.rs:146:43
|
146 | let note = to.create_note(asset_type, value.into(), rseed);
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
associated function `to_le_bits` is never used:
masp_primitives/src/sapling.rs#L546
error: associated function `to_le_bits` is never used
--> masp_primitives/src/sapling.rs:546:19
|
546 | pub(crate) fn to_le_bits(self) -> BitArray<[u8; 8], Lsb0> {
| ^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
using `clone` on type `sapling::Note` which implements the `Copy` trait:
masp_primitives/src/transaction/components/sapling/builder.rs#L170
error: using `clone` on type `sapling::Note` which implements the `Copy` trait
--> masp_primitives/src/transaction/components/sapling/builder.rs:170:64
|
170 | let encryptor = sapling_note_encryption::<P>(self.ovk, self.note.clone(), self.memo);
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.note`
|
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
you are deriving `PartialEq` and can implement `Eq`:
masp_primitives/src/transaction/components/sapling/builder.rs#L69
error: you are deriving `PartialEq` and can implement `Eq`
--> masp_primitives/src/transaction/components/sapling/builder.rs:69:24
|
69 | #[derive(Debug, Clone, PartialEq)]
| ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
|
useless conversion to the same type: `u64`:
masp_primitives/src/transaction/builder.rs#L257
error: useless conversion to the same type: `u64`
--> masp_primitives/src/transaction/builder.rs:257:81
|
257 | .add_output(&mut self.rng, ovk, to, asset_type, NoteValue::from_raw(value.into()), memo)
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `sapling::NoteValue`:
masp_primitives/src/sapling.rs#L871
error: useless conversion to the same type: `sapling::NoteValue`
--> masp_primitives/src/sapling.rs:871:24
|
871 | value: value.into(),
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `u64`:
masp_primitives/src/sapling/note_encryption.rs#L146
error: useless conversion to the same type: `u64`
--> masp_primitives/src/sapling/note_encryption.rs:146:43
|
146 | let note = to.create_note(asset_type, value.into(), rseed);
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
associated function `to_le_bits` is never used:
masp_primitives/src/sapling.rs#L546
error: associated function `to_le_bits` is never used
--> masp_primitives/src/sapling.rs:546:19
|
546 | pub(crate) fn to_le_bits(self) -> BitArray<[u8; 8], Lsb0> {
| ^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
Lint
Clippy had exited with the 101 exit code
|
using `clone` on type `sapling::Note` which implements the `Copy` trait:
masp_primitives/src/transaction/components/sapling/builder.rs#L170
error: using `clone` on type `sapling::Note` which implements the `Copy` trait
--> masp_primitives/src/transaction/components/sapling/builder.rs:170:64
|
170 | let encryptor = sapling_note_encryption::<P>(self.ovk, self.note.clone(), self.memo);
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.note`
|
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
you are deriving `PartialEq` and can implement `Eq`:
masp_primitives/src/transaction/components/sapling/builder.rs#L69
error: you are deriving `PartialEq` and can implement `Eq`
--> masp_primitives/src/transaction/components/sapling/builder.rs:69:24
|
69 | #[derive(Debug, Clone, PartialEq)]
| ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
|
useless conversion to the same type: `u64`:
masp_primitives/src/transaction/builder.rs#L257
error: useless conversion to the same type: `u64`
--> masp_primitives/src/transaction/builder.rs:257:81
|
257 | .add_output(&mut self.rng, ovk, to, asset_type, NoteValue::from_raw(value.into()), memo)
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `sapling::NoteValue`:
masp_primitives/src/sapling.rs#L871
error: useless conversion to the same type: `sapling::NoteValue`
--> masp_primitives/src/sapling.rs:871:24
|
871 | value: value.into(),
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `u64`:
masp_primitives/src/sapling/note_encryption.rs#L644
error: useless conversion to the same type: `u64`
--> masp_primitives/src/sapling/note_encryption.rs:644:47
|
644 | let note = pa.create_note(asset_type, value.into(), rseed);
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `u64`:
masp_primitives/src/sapling/note_encryption.rs#L146
error: useless conversion to the same type: `u64`
--> masp_primitives/src/sapling/note_encryption.rs:146:43
|
146 | let note = to.create_note(asset_type, value.into(), rseed);
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
associated function `to_le_bits` is never used:
masp_primitives/src/sapling.rs#L546
error: associated function `to_le_bits` is never used
--> masp_primitives/src/sapling.rs:546:19
|
546 | pub(crate) fn to_le_bits(self) -> BitArray<[u8; 8], Lsb0> {
| ^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
using `clone` on type `sapling::Note` which implements the `Copy` trait:
masp_primitives/src/transaction/components/sapling/builder.rs#L170
error: using `clone` on type `sapling::Note` which implements the `Copy` trait
--> masp_primitives/src/transaction/components/sapling/builder.rs:170:64
|
170 | let encryptor = sapling_note_encryption::<P>(self.ovk, self.note.clone(), self.memo);
| ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.note`
|
= note: `-D clippy::clone-on-copy` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
you are deriving `PartialEq` and can implement `Eq`:
masp_primitives/src/transaction/components/sapling/builder.rs#L69
error: you are deriving `PartialEq` and can implement `Eq`
--> masp_primitives/src/transaction/components/sapling/builder.rs:69:24
|
69 | #[derive(Debug, Clone, PartialEq)]
| ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
|
= note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
|
useless conversion to the same type: `u64`:
masp_primitives/src/transaction/builder.rs#L257
error: useless conversion to the same type: `u64`
--> masp_primitives/src/transaction/builder.rs:257:81
|
257 | .add_output(&mut self.rng, ovk, to, asset_type, NoteValue::from_raw(value.into()), memo)
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `sapling::NoteValue`:
masp_primitives/src/sapling.rs#L871
error: useless conversion to the same type: `sapling::NoteValue`
--> masp_primitives/src/sapling.rs:871:24
|
871 | value: value.into(),
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
useless conversion to the same type: `u64`:
masp_primitives/src/sapling/note_encryption.rs#L146
error: useless conversion to the same type: `u64`
--> masp_primitives/src/sapling/note_encryption.rs:146:43
|
146 | let note = to.create_note(asset_type, value.into(), rseed);
| ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
|
= note: `-D clippy::useless-conversion` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
|
associated function `to_le_bits` is never used:
masp_primitives/src/sapling.rs#L546
error: associated function `to_le_bits` is never used
--> masp_primitives/src/sapling.rs:546:19
|
546 | pub(crate) fn to_le_bits(self) -> BitArray<[u8; 8], Lsb0> {
| ^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
|
Nightly lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|