Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the serialization of transaction build parameters. #84

Merged
merged 1 commit into from
May 27, 2024

Conversation

murisi
Copy link
Contributor

@murisi murisi commented May 22, 2024

Made changes to facilitate the implementation of MASP hardware wallet support with hardware generated randomness. More specifically, the following has been done:

  • Allow the randomness used to generate a MASP Transaction to be stored in the hardware wallet's format (which uses vectors and discards the random number generator). This was done by creating a to_stored method.
  • Implemented the Borsh serialization and deserialization traits for StoredBuildParams and its subcomponents. This is done to facilitate test vector creation and the reading of randomness parameters from the hardware wallet.
  • Implemented the Borsh schema for StoredBuildParams and its subcomponents. This was done to ease the communication of the structure of the randomness parameters.

@murisi murisi merged commit 4ede1c4 into main May 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants