Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

masp_proofs: do not enable getrandom's "js" feature by default #85

Merged
merged 2 commits into from
Jun 25, 2024
Merged

masp_proofs: do not enable getrandom's "js" feature by default #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4481a82
masp_proofs: do not enable getrandom's "js" feature by default
tzemanovic Jun 25, 2024
bfca963
ci/build: use "js" feature to test wasm build
tzemanovic Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- run: cargo fetch
- name: Build masp_proofs for target
working-directory: ./masp_proofs
run: cargo build --verbose --no-default-features --target ${{ matrix.target }}
run: cargo build --verbose --no-default-features --target ${{ matrix.target }} --features js


bitrot:
Expand Down
3 changes: 2 additions & 1 deletion masp_proofs/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ blake2b_simd = "1"
directories = { version = "4", optional = true }
# This pulls the reddsa library that contains hardcoded personalizations and basepoints. If you need to work on a new project consider forking `reddsa`, modifying it to your needs and patching it in the root manifest
redjubjub = "0.7"
getrandom = { version = "0.2", features = ["js"] }
getrandom = { version = "0.2" }
itertools = "0.11"

[dev-dependencies]
Expand All @@ -53,6 +53,7 @@ local-prover = ["directories"]
multicore = ["bellman/multicore"]
embed-verifying-key = []
benchmarks = []
js = ["getrandom/js"]

[lib]
bench = false
Expand Down
Loading