-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/box impl build params #88
Open
murisi
wants to merge
8
commits into
main
Choose a base branch
from
murisi/box-impl-build-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/box-impl-build-params
branch
from
September 10, 2024 10:21
7b2316a
to
f2b0cae
Compare
1 task
…perceded by the ExtendedKey trait. Removed BuildParams::auth_sig because signatures can be modified after the build using the MapAuth trait.
murisi
force-pushed
the
murisi/box-impl-build-params
branch
from
September 24, 2024 20:22
dacba7f
to
2914e6f
Compare
tzemanovic
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo fmt). The MaybeArbitrary
is also a lot cleaner than before, thanks for refactoring it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some changes to facilitate the signing of MASP
Transaction
s using the hardware wallet:BuildParams
for boxes to enable consumers to dynamically switch betweenRngBuildParams
andStoredBuildParams
ask
,ak
,nsk
, andnk
to allow consumers to force transaction construction in the presence of inconsistencies/incomplete information (like knownak
but unknownask
)ExtendedSpendingKey
which might not enforce certain relations to be used