Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/box impl build params #88

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Sep 10, 2024

Implemented some changes to facilitate the signing of MASP Transactions using the hardware wallet:

  • Implemented BuildParams for boxes to enable consumers to dynamically switch between RngBuildParams and StoredBuildParams
  • Make authorization mappers provide positional information to allow bundle signatures to be replaced with an ordered list (coming from the hardware wallet)
  • Made a new key type that explicitly stores ask, ak, nsk, and nk to allow consumers to force transaction construction in the presence of inconsistencies/incomplete information (like known ak but unknown ask)
  • Generalized transaction Builders to allow key implementations other than ExtendedSpendingKey which might not enforce certain relations to be used

…perceded by the ExtendedKey trait. Removed BuildParams::auth_sig because signatures can be modified after the build using the MapAuth trait.
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo fmt). The MaybeArbitrary is also a lot cleaner than before, thanks for refactoring it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants