Alpha 13 #81
Merged
Alpha 13 #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cardholder detail returns an AccessZone for the last_successful_access_zone but does not send an identifier in that response, this relaxes the identifier field so the same Ref can be used in other usecases along with CardholderSummary
i used to this was worth something but with automation i am happy to get rid of this
There was a problem hiding this comment.
Pull Request Overview
This PR relaxes the identifier rule for zone references by switching from IdentityMixin to OptionalIdentityMixin, and it updates the CardholderDetail model to reflect this change.
- Replaces IdentityMixin with OptionalIdentityMixin in AccessZoneRef
- Updates CardholderDetail to include new optional fields (last_successful_access_zone, last_successful_access_time, and server_display_name)
- Removes the version test, which may need reconsideration given the new versioning scheme
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_version.py | Removed version check test; consider updating it to reflect the new version “Alpha 13” |
| gallagher/dto/ref/zone.py | Updated AccessZoneRef to use OptionalIdentityMixin in line with relaxed identifier rules |
| gallagher/dto/detail/cardholder.py | Added new optional fields for access zone and additional details in cardholder information |
Comments suppressed due to low confidence (1)
tests/test_version.py:1
- The removal of the version test means that the version validation isn't automatically checked; consider updating or replacing this test to validate that the new version 'Alpha 13' is correctly set.
Removed version test comparing __version__ to "0.1.0a12"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💅 Improves
AccessZoneRefnow has anOptional,Identifier.last_successful_access_zoneonCardholderDetaildoes not send back anIdentifierbut all other responses using theRefdo, it was wiser to relax this rule.