Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert stable 8 backports #2462

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Revert stable 8 backports #2462

merged 4 commits into from
Jan 14, 2025

Conversation

hakbailey
Copy link
Contributor

SUMMARY

Reverts two backports for minor features that were intended to be released in 8.3.0, but were instead released in 9.0.0. As such, they are being removed from this branch to reflect what we actually did.

@hakbailey
Revert "ec2_vpc_route_table: Add support to
e6ecf01 
configure Transit Gateway routes in route table (ansible-collections#2291) (ansible-collections#2295)"

This reverts commit 85ad721.

Feature was released in 9.0.0.
@hakbailey
Revert "cloudwatchlogs_log_group_metric_filter:
aef49ad 
add support for unit and dimensions (ansible-collections#2286) (ansible-collections#2361)"

This reverts commit a5d458a.

Feature was released in 9.0.0.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

alinabuzachis
alinabuzachis approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably would have preferred two different PRs for each revert, but LGTM!

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f0ed7bfaa32c4fd68b30e069dc0d91f9

✔️ ansible-galaxy-importer SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 10m 19s
✔️ ansible-test-splitter SUCCESS in 3m 51s
✔️ integration-amazon.aws-1 SUCCESS in 17m 16s
✔️ integration-amazon.aws-2 SUCCESS in 6m 13s
Skipped 42 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 14, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a290cfc38bff4a57ac751afc9ae8594e

✔️ ansible-galaxy-importer SUCCESS in 8m 18s
✔️ build-ansible-collection SUCCESS in 10m 38s
✔️ ansible-test-splitter SUCCESS in 4m 14s
✔️ integration-amazon.aws-1 SUCCESS in 19m 26s
✔️ integration-amazon.aws-2 SUCCESS in 5m 36s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5fa6089 into ansible-collections:stable-8 Jan 14, 2025
45 checks passed
@hakbailey hakbailey deleted the revert-stable-8-backports branch January 14, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@gravesm gravesm gravesm approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hakbailey @tremble @gravesm @alinabuzachis