Skip to content

Allow modifying the backup_retention_period option. #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow modifying the backup_retention_period option. #2579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ac94a7
Allow modifying the backup_retention_period option. . When it was set…
alinabuzachis Apr 17, 2025
30ccef9
Update 20250417-rds_instance-retention.yml
alinabuzachis Apr 17, 2025
34f02ba
Allow modifying the backup_retention_period option. . When it was set…
alinabuzachis Apr 17, 2025
882e285
update
alinabuzachis Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/20250417-rds_instance-retention.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- rds_instance - Allow modifying the ``backup_retention_period`` option. When it was set, the value provided was ignored (https://github.com/ansible-collections/amazon.aws/pull/2579).
4 changes: 4 additions & 0 deletions plugins/modules/rds_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,6 +1187,10 @@ def get_options_with_changing_values(client, module: AnsibleAWSModule, parameter
):
parameters.pop("NewDBInstanceIdentifier")

backup_retention_period = module.params.get("backup_retention_period")
if instance.get("BackupRetentionPeriod") != backup_retention_period:
parameters["BackupRetentionPeriod"] = backup_retention_period

if parameters:
parameters["DBInstanceIdentifier"] = instance_id
if apply_immediately is not None:
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/targets/rds_instance_complex/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@
that:
- result.changed
- result.db_instance_identifier == instance_id
- '"backup_retention_period" in result'
- result.backup_retention_period | int == 0'

- name: Add IAM roles to mariab (should fail - iam roles not supported for mariadb)
amazon.aws.rds_instance:
Expand Down Expand Up @@ -130,6 +132,8 @@
- '"port" in result.pending_modified_values or result.endpoint.port == 1150'
- '"db_instance_class" in result.pending_modified_values or result.db_instance_class == modified_db_instance_class'
- '"monitoring_interval" in result.pending_modified_values or result.monitoring_interval == monitoring_interval'
- '"backup_retention_period" in result'
- result.backup_retention_period | int == 0'

- name: Idempotence modifying several pending attributes - check_mode
amazon.aws.rds_instance:
Expand Down Expand Up @@ -179,6 +183,8 @@
- '"max_allocated_storage" in result.pending_modified_values or result.max_allocated_storage == 150'
- '"port" in result.pending_modified_values or result.endpoint.port == 1150'
- '"db_instance_class" in result.pending_modified_values or result.db_instance_class == modified_db_instance_class'
- '"backup_retention_period" in result'
- result.backup_retention_period | int == 0'

always:
- name: Delete the instance
Expand Down
Loading