-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate: Add suppress_output option to jsonschema validator #374
base: main
Are you sure you want to change the base?
validate: Add suppress_output option to jsonschema validator #374
Conversation
6ee10f6
to
b4a0a01
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s |
0448135
to
d8f536a
Compare
6b92fc6
to
bf6425d
Compare
pre-commit.ci autofix |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 25s |
@lisongmin thanks for raising this PR, just a small request could you kindly add changelog and integration tests to validate this following change? |
Signed-off-by: Songmin Li <[email protected]>
ad02898
to
778faf6
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 04s |
Done
|
Co-authored-by: Ruchi Pakhle <[email protected]>
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 2m 54s |
SUMMARY
Add suppress_output option to jsonschema validator
ISSUE TYPE
COMPONENT NAME
validate
ADDITIONAL INFORMATION
When validate a json schema failed, the error block contains the source data and criteria.
And the data and criteria are usually too large, so we can't find the error message quickly.
Also the data may contains sensitive info that we don't want to show out.
This PR provides a way to suppress the data and criteria in the error block