Add in check_mode to be supported for eos_route_maps #480

jakegroves · 2023-11-08T21:56:51Z

SUMMARY

Fixes the ability to see the --check mode, so can check changes before running.

ISSUE TYPE

Bugfix Pull Request (Fixes eos_route_maps module does not have check mode #481)

COMPONENT NAME

eos_route_maps

ADDITIONAL INFORMATION

Example playbook

- name: Replace provided route map configuration
  arista.eos.eos_route_maps:
    state: replaced
    config: "{{ eos_route_maps.config }}"
  register: replace_route_map_command

- name: Display route map changes
  debug:
    var: replace_route_map_command.commands
  when: replace_route_map_command is changed

Before changes:

PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
skipping: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
skipping: [router1]

After changes:

PLAY [router] ***************************************************************************************************************************************************************************************************************************************

TASK [route_map : Replace provided route map configuration] *****************************************************************************************************************************************************************************************
changed: [router1]

TASK [route_map : Display route map changes] ********************************************************************************************************************************************************************************************************
ok: [router1] => {
    "replace_route_map_command.commands": [
        "route-map Example-RM permit 10",
        "set local-preference 110"
    ]
}

codecov · 2023-11-08T21:59:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef5facc) 82.76% compared to head (71f52de) 82.75%.

❗ Current head 71f52de differs from pull request most recent head a28b730. Consider uploading reports for the commit a28b730 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   82.76%   82.75%   -0.01%     
==========================================
  Files         153      153              
  Lines       11967    11967              
==========================================
- Hits         9904     9903       -1     
- Misses       2063     2064       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

softwarefactory-project-zuul · 2023-11-08T22:56:04Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/60ac826e876644a6a229d253716d0a3b

softwarefactory-project-zuul · 2023-11-29T12:11:46Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a05893d7b3434d3dadf0ee363a4745a7

github-actions · 2023-12-06T22:28:26Z

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

softwarefactory-project-zuul · 2023-12-06T23:31:24Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5861fece5c4e45d8a7692d891acf8695

Ruchip16 · 2025-08-07T19:23:31Z

@jakegroves thanks for working on this, can we also add some tests to validate this change since its been a while now?

surudhi · 2025-08-20T14:53:05Z

Hi, thanks for putting this PR together — this feature would be really useful for my work as well. Is there anything we can do to help move this forward?

for more information, see https://pre-commit.ci

jakegroves · 2025-09-15T22:53:27Z

Hi, thanks for putting this PR together — this feature would be really useful for my work as well. Is there anything we can do to help move this forward?

@surudhi @Ruchip16 not sure what else is needed really, i don't see any pre-existing tests of other plugins for this, and it's in the same functionality as eos_prefix_list for example

surudhi · 2025-09-22T18:55:55Z

Hi, thanks for putting this PR together — this feature would be really useful for my work as well. Is there anything we can do to help move this forward?

@surudhi @Ruchip16 not sure what else is needed really, i don't see any pre-existing tests of other plugins for this, and it's in the same functionality as eos_prefix_list for example

@Ruchip16 can we get this change merged for the next release?

jakegroves temporarily deployed to ack November 8, 2023 21:56 — with GitHub Actions Inactive

pre-commit-ci bot temporarily deployed to ack November 8, 2023 21:57 Inactive

jakegroves mentioned this pull request Nov 8, 2023

eos_route_maps module does not have check mode #481

Open

NilashishC approved these changes Nov 17, 2023

View reviewed changes

rohitthakur2590 temporarily deployed to ack November 29, 2023 11:06 — with GitHub Actions Inactive

jakegroves force-pushed the route_map_check_mode branch from f4b6416 to a28b730 Compare December 6, 2023 22:28

jakegroves had a problem deploying to ack December 6, 2023 22:28 — with GitHub Actions Failure

Ruchip16 temporarily deployed to push August 7, 2025 19:22 — with GitHub Actions Inactive

Ruchip16 self-requested a review August 7, 2025 19:23

jakegroves force-pushed the route_map_check_mode branch from 41ea2e5 to 6984a67 Compare August 21, 2025 00:11

jakegroves temporarily deployed to push August 21, 2025 00:11 — with GitHub Actions Inactive

jakegroves temporarily deployed to push September 15, 2025 22:39 — with GitHub Actions Inactive

jagexjake and others added 2 commits September 15, 2025 23:50

Add in check_mode to be supported for eos_route_maps

3780ed4

[pre-commit.ci] auto fixes from pre-commit.com hooks

e5fd749

for more information, see https://pre-commit.ci

jakegroves force-pushed the route_map_check_mode branch from cfd44a9 to e5fd749 Compare September 15, 2025 22:50

jakegroves temporarily deployed to push September 15, 2025 22:50 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add in check_mode to be supported for eos_route_maps #480

Add in check_mode to be supported for eos_route_maps #480

Uh oh!

jakegroves commented Nov 8, 2023 •

edited

Loading

Uh oh!

codecov bot commented Nov 8, 2023 •

edited

Loading

Uh oh!

softwarefactory-project-zuul bot commented Nov 8, 2023

Uh oh!

softwarefactory-project-zuul bot commented Nov 29, 2023

Uh oh!

github-actions bot commented Dec 6, 2023

Uh oh!

softwarefactory-project-zuul bot commented Dec 6, 2023

Uh oh!

Ruchip16 commented Aug 7, 2025

Uh oh!

surudhi commented Aug 20, 2025

Uh oh!

jakegroves commented Sep 15, 2025 •

edited

Loading

Uh oh!

surudhi commented Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add in check_mode to be supported for eos_route_maps #480

Are you sure you want to change the base?

Add in check_mode to be supported for eos_route_maps #480

Uh oh!

Conversation

jakegroves commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Uh oh!

codecov bot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

softwarefactory-project-zuul bot commented Nov 8, 2023

Uh oh!

softwarefactory-project-zuul bot commented Nov 29, 2023

Uh oh!

github-actions bot commented Dec 6, 2023

Uh oh!

softwarefactory-project-zuul bot commented Dec 6, 2023

Uh oh!

Ruchip16 commented Aug 7, 2025

Uh oh!

surudhi commented Aug 20, 2025

Uh oh!

jakegroves commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

surudhi commented Sep 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jakegroves commented Nov 8, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading

jakegroves commented Sep 15, 2025 •

edited

Loading