eos_acls: Fix missing 'standard' keyword in replaced state #613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



SUMMARY
Fixes issue where
eos_aclsmodule withstate: replaceddid not generate thestandardkeyword for standard ACLs.When using
state: "replaced"on a standard ACL, the generated commands were missing thestandardkeyword (e.g.,ip access-list test-aclinstead ofip access-list standard test-acl). This caused the ACL to be created as an extended ACL instead of a standard one.The fix ensures that the
standardkey from the ACL configuration is properly passed to the command generation logic for new ACLs in replaced state.Fixes #608
ISSUE TYPE
COMPONENT NAME
eos_acls
ADDITIONAL INFORMATION
Before the fix:
Generated commands (incorrect):
After the fix:
Generated commands (correct):
Changes made:
_state_replacedinplugins/module_utils/network/eos/config/acls/acls.pyto pass the full ACL configuration (includingstandardkey) when creating new ACLstest_eos_acls_replaced_standardandtest_eos_acls_replaced_extended