Skip to content

Conversation

@nickbhasin
Copy link
Contributor

@nickbhasin nickbhasin commented Dec 10, 2025

Description

  • What is being changed?
    Code Cleanup - Disabled CI Removal and tests workflow refactor to make in align with other ansible collections
    Renames integration tests files like single.yaml to downstream.yaml.
  • Why is this change needed?
    Unnecessary skipped runs during tests.yml workflow run
  • How does this change address the issue?
    It removes the 'if conditions' and streamlines everything to pull_request_target

Type of Change

  • [] CI maintenance
  • [] Workflow maintenance

Related Issue

  • Fixes Unnecessary skipped runs during tests.yml workflow run
  • Related to #

Component Name

workflows/tests.yml
workflows/codecoverage.yml
tests/integration

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have removed all commented code (no commented code should be merged)
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment
  • I have verified the changes work with the target EOS version(s)
  • I have reviewed the acceptance criteria for related tickets

Testing Instructions

Prerequisites

  • EOS Version:
  • Hardware Platform (if applicable):
  • Test Topology:

Steps to Test

  1. Create/Merge any PR and check if any runs are getting skipped.

Expected Results

Test Results

Acceptance Criteria Verification

  • All acceptance criteria have been reviewed and verified
  • Acceptance criteria checklist:
    • [ ]
    • [ ]
    • [ ]

Additional Context

Command Output / Logs

<!-- Paste below -->

Required Actions

  • Requires documentation updates
  • Requires changelog fragment
  • Requires integration test updates
  • Requires unit test updates
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs

Breaking Changes

Removed commented-out Codecov badge from README.
@KB-perByte KB-perByte merged commit 884c086 into ansible-collections:main Dec 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants