Skip to content

Distinguish between upload methods of type blob and page #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xuzhang3 merged 1 commit into from
Feb 6, 2025
Merged

Distinguish between upload methods of type blob and page #1798

xuzhang3 merged 1 commit into from
Feb 6, 2025

Conversation

@Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Jan 6, 2025 •
edited
Loading

SUMMARY

Distinguish between upload methods of type 'blob' and 'page', try to fixes #1794

        :keyword ~azure.storage.blob.StandardBlobTier standard_blob_tier:
            A standard blob tier value to set the blob to. For this version of the library,
            this is only applicable to block blobs on standard storage accounts
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_storageblob.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun changed the title Distinguish between upload methods of type 'blob' and 'page' Distinguish between upload methods of type blob and page Jan 6, 2025
@Fred-sun Fred-sun mentioned this pull request Jan 6, 2025
Closed
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority high_priority High priority labels Jan 6, 2025
cmasopust
cmasopust approved these changes Feb 5, 2025
View reviewed changes
Copy link

@cmasopust cmasopust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change locally and can confirm that uploading is now working as expected.

@xuzhang3 xuzhang3 merged commit 796e62f into ansible-collections:dev Feb 6, 2025
@cmasopust cmasopust mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuzhang3 xuzhang3 xuzhang3 approved these changes

+1 more reviewer

@cmasopust cmasopust cmasopust approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@xuzhang3 xuzhang3

Labels

high_priority High priority medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

azure_rm_storageblob: no longer able to upload image with blob_type 'page'

3 participants

@Fred-sun @xuzhang3 @cmasopust