Skip to content

Module sending No Shut command #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nickbhasin
Copy link
Contributor

@nickbhasin nickbhasin commented May 9, 2025

SUMMARY

Fixes incorrect handling of the enabled (shutdown/no shutdown) state within the cisco.iosxr.iosxr_interfaces module when configuration changes detected.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

cisco.iosxr.iosxr_interfaces

INFO

This change updates the configs to assume interfaces are enabled (no shutdown) by default unless a shutdown command is explicitly found.
It reflects the default Cisco IOSXR behavior, where interfaces are administratively up unless shut down.
Removed the default value for enabled from True.
Removed the check to add enabled = True for validating the default value set to True.

@nickbhasin nickbhasin marked this pull request as ready for review May 9, 2025 11:03
@nickbhasin nickbhasin marked this pull request as draft May 9, 2025 11:04
@nickbhasin nickbhasin marked this pull request as ready for review May 13, 2025 07:42
@roverflow roverflow merged commit 64428c8 into ansible-collections:main May 14, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants