-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commands for community group and host VRF #795
Draft
TheRealBecks
wants to merge
8
commits into
ansible-collections:main
Choose a base branch
from
TheRealBecks:794_snmp_wrong_commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix commands for community group and host VRF #795
TheRealBecks
wants to merge
8
commits into
ansible-collections:main
from
TheRealBecks:794_snmp_wrong_commands
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
for more information, see https://pre-commit.ci
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
TheRealBecks
changed the title
Fix community group command
Fix commands for community group and host VRF
Dec 19, 2023
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft
SUMMARY
Fixes #794
ISSUE TYPE
COMPONENT NAME
nxos_snmp_server
ADDITIONAL INFORMATION
I changed the
community
command logic to theuser
command logic, so I had to split it fromcommunity
tocommunity.groups
andcommunity.use_acls
. Therefore also the data structure has to be changed what makes this PR incompatible with older versions:https://github.com/ansible-collections/cisco.nxos/pull/795/files#diff-94d7a7b6fd06a67cd2fa5a720e80962f8b320dfe00016a8e3dc58bd4f8163abaR43-R66
I will also provide the changes needed for the host VRF.
❓ Do these changes match your expectations?
If yes then the following changes need to be made: