Feature filter replace_keys #8446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbotka this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
feature
vbotka
force-pushed
the
feature-filter-replace_keys
branch
from
696bd5d to
81d52c6
Compare
ansibullbot
added
integration
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
felixfontein
added
check-before-release
ansibullbot
added
needs_ci
vbotka
force-pushed
the
feature-filter-replace_keys
branch
from
dde2649 to
3088f38
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
vbotka
force-pushed
the
feature-filter-replace_keys
branch
from
3088f38 to
37cf3a7
Compare
ansibullbot
removed
ci_verified
|
community.general 9 requires ansible-core 2.13+, which requires Python 3.8+ on the controller. So there's no need to worry about Python 3.5 and earlier for filters :) |
felixfontein
reviewed
Jun 8, 2024
felixfontein
reviewed
Jun 8, 2024
* No target testing in _keys_filter_params * Interface changed _keys_filter_params(data, matching_parameter) * If there are items with equal C(before) the B(first) one will be used.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
Co-authored-by: Felix Fontein <[email protected]>
ansibullbot
removed
the
needs_revision
|
Done. Thank you! |
felixfontein
approved these changes
Jun 14, 2024
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8507 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
* Add filter replace_keys. * Update examples and integration tests. * Fix examples and copyright. * Update documentation, examples and integration tests. * Implement #8445. Add filter replace_keys * Fix documentation formatting. * Fix documentation. * Fix type(target). Formatting improved. * Instead of a dictionary, _keys_filter_target_dict returns a list * No target testing in _keys_filter_params * Interface changed _keys_filter_params(data, matching_parameter) * If there are items with equal C(before) the B(first) one will be used. * Update remove_keys. Interface changed _keys_filter_params(data, matching_parameter) * The target can't be empty also in _keys_filter_target_dict * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Test attributes before and after are strings in the iteration of target. * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 1d61541)
felixfontein
removed
the
check-before-release
|
@vbotka thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 15, 2024
…8507) Feature filter replace_keys (#8446) * Add filter replace_keys. * Update examples and integration tests. * Fix examples and copyright. * Update documentation, examples and integration tests. * Implement #8445. Add filter replace_keys * Fix documentation formatting. * Fix documentation. * Fix type(target). Formatting improved. * Instead of a dictionary, _keys_filter_target_dict returns a list * No target testing in _keys_filter_params * Interface changed _keys_filter_params(data, matching_parameter) * If there are items with equal C(before) the B(first) one will be used. * Update remove_keys. Interface changed _keys_filter_params(data, matching_parameter) * The target can't be empty also in _keys_filter_target_dict * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Test attributes before and after are strings in the iteration of target. * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 1d61541) Co-authored-by: Vladimir Botka <[email protected]>
|
@felixfontein I appreciate your cooperation! |
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
* Add filter replace_keys. * Update examples and integration tests. * Fix examples and copyright. * Update documentation, examples and integration tests. * Implement ansible-collections#8445. Add filter replace_keys * Fix documentation formatting. * Fix documentation. * Fix type(target). Formatting improved. * Instead of a dictionary, _keys_filter_target_dict returns a list * No target testing in _keys_filter_params * Interface changed _keys_filter_params(data, matching_parameter) * If there are items with equal C(before) the B(first) one will be used. * Update remove_keys. Interface changed _keys_filter_params(data, matching_parameter) * The target can't be empty also in _keys_filter_target_dict * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Test attributes before and after are strings in the iteration of target. * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
austinlucaslake
pushed a commit
to austinlucaslake/community.general
that referenced
this pull request
Mar 14, 2025
* Add filter replace_keys. * Update examples and integration tests. * Fix examples and copyright. * Update documentation, examples and integration tests. * Implement ansible-collections#8445. Add filter replace_keys * Fix documentation formatting. * Fix documentation. * Fix type(target). Formatting improved. * Instead of a dictionary, _keys_filter_target_dict returns a list * No target testing in _keys_filter_params * Interface changed _keys_filter_params(data, matching_parameter) * If there are items with equal C(before) the B(first) one will be used. * Update remove_keys. Interface changed _keys_filter_params(data, matching_parameter) * The target can't be empty also in _keys_filter_target_dict * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> * Test attributes before and after are strings in the iteration of target. * Update plugins/filter/replace_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implement #8445
ISSUE TYPE
COMPONENT NAME
community.general.replace_keys
ADDITIONAL INFORMATION
See related feature requests #8438, #8442, and PR #8456, #8443