Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ready for data tagging #9833

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

This adds ansible/ansible#84621 to CI to test whether it causes problems in CI.

Ref: https://forum.ansible.com/t/data-tagging-preview-and-testing/40759
Ref: https://forum.ansible.com/t/data-tagging-playground/39909

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

CI

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added WIP Work in progress tests tests unit tests/unit labels Mar 5, 2025
@ansibullbot

This comment was marked as outdated.

@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 6, 2025
@felixfontein

This comment was marked as outdated.

@felixfontein

This comment was marked as outdated.

@felixfontein felixfontein added backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch labels Mar 8, 2025
@ansibullbot ansibullbot added integration tests/integration lookup lookup plugin plugins plugin (any type) labels Mar 8, 2025
@felixfontein felixfontein force-pushed the ci-data-tagging branch 3 times, most recently from 017513e to 9d501ca Compare March 8, 2025 14:01
@felixfontein felixfontein changed the title [DO NOT MERGE] Add data tagging PR to CI [WIP] Add data tagging PR to CI Mar 8, 2025
@felixfontein felixfontein changed the title [WIP] Add data tagging PR to CI [WIP] Make ready for data tagging Mar 8, 2025
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Mar 19, 2025
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Mar 22, 2025
@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Mar 23, 2025
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added has_issue and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Mar 23, 2025
@felixfontein
Copy link
Collaborator Author

@russoz regarding the YAML plugin, what do you think about the following:

  1. move the removal of the yaml callback to community.general 12.0.0 (right now it's announced to be removed from 13.0.0);
  2. wrap the definition of MyDumper in a try/catch that - inside the catch block - does some imports of internal ansible-core things to "make it work".

That way we only have to support it up to ansible-core 2.20 (which hopefully will limit the number of breakages caused by the internal imports to a minimum).

We could even remove it from 11.0.0 (the next release coming up in May) so we only ever have to support internals from ansible-core 2.19. But that would be not so nice for users since it only got deprecated in community.general 10.2.0 released on December 31st, 2024.

@felixfontein
Copy link
Collaborator Author

I removed 9becd3f since raw_get() has been added back temporarily, see ansible/ansible#84799 (comment).

@felixfontein felixfontein force-pushed the ci-data-tagging branch 2 times, most recently from 5515505 to ff4fc6a Compare March 29, 2025 09:57
@felixfontein
Copy link
Collaborator Author

wrap the definition of MyDumper in a try/catch that - inside the catch block - does some imports of internal ansible-core things to "make it work".

I have implemented this, and it works well.

@russoz what do you think of moving the removal of the yaml callback to 12.0.0 (instead of 13.0.0)?

@felixfontein
Copy link
Collaborator Author

(This is the first time that CI for this PR is actually green :) )

@felixfontein
Copy link
Collaborator Author

Restart CI.

@felixfontein felixfontein reopened this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch callback callback plugin filter filter plugin has_issue integration tests/integration lookup lookup plugin plugins plugin (any type) tests tests unit tests/unit WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants