fix validate_certs parameter beeing ignored when used with the retries parameter #462
Conversation
…as set. Fix now also sets the parameter correctly in the retry request session Closes ansible-collections#461
| @@ -108,7 +108,7 @@ def _filter(k, v): | |||
|
|
|||
| retry_action = hvopts.pop('retry_action') | |||
| if 'retries' in hvopts: | |||
| hvopts['session'] = self._get_custom_requests_session(new_callback=self._retry_callback_generator(retry_action), **hvopts.pop('retries')) | |||
| hvopts['session'] = self._get_custom_requests_session(new_callback=self._retry_callback_generator(retry_action), conopt_verify=self._conopt_verify, **hvopts.pop('retries')) | |||
There was a problem hiding this comment.
I'm debating whether we should bother passing this as parameter. Instead, we can make the original call here, and then set hvopts['session'].verify = self._conopt_verify. It feels like that may be the correct place to do this. Let me know if you object.
There was a problem hiding this comment.
We can do it the way you suggested. I actually had it that way in my first draft, but then I thought it wouldn't match the rest of the style of the code and changed it.
Should I change it?
|
if possible, it would be great to introduce a test that would have caught this as well |
…d changes Co-authored-by: Brian Scholer <[email protected]>
I can try to write a test for it. I just need to have a quick look at how it works, as I normally don't program in Python. |
…retries and modified the corresponding unit test
SUMMARY
I run a local vault instance with a self-signed certificate. For this reason I have set the
validate_certsparameter to False. However, when I then used the vault_kv2_get module or lookup plugin in combination with theretriesparameter, the query still failed because the certificate validation was performed.This was because the validate property of the retry request session was not set correctly. I fixed this error with this pull request.
Fixes #461
ISSUE TYPE