Skip to content

Fix A record example to prevent unintended nested DNS zone creation #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

chuckmilam
Copy link
Contributor

SUMMARY

Creating an "A" record with a FQDN in the "name:" module argument creates a nested DNS zone, which is not expected behavior, and can break AD DNS replication. Updates first example to remove the FQDN.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

win_dns_record.py

ADDITIONAL INFORMATION

In the first example, we use FQDN in the "name" module argument:

- name: Create database server record
  community.windows.win_dns_record:
    name: "cgyl1404p.amer.example.com"
    type: "A"
    value: "10.1.1.1"
    zone: "amer.example.com"

This creates a "nested" DNS zone (amer.example.com.amer.example.com), which is not intended behavior and can break AD DNS replication.

The "name:" module argument should not use FQDN, which is properly shown in the later example for "Create Multiple A record values for www", as well as other examples using the "A" record type module argument.

…d DNS zone

Creating an "A" record as shown in the first example creates a nested DNS zone (amer.example.com.amer.example.com), which is not expected behavior. The "name:" module argument should not use a FQDN, which is properly shown in the later example for "Create Multiple A record values for www."
@jborean93
Copy link
Collaborator

Sorry for the delay in reviewing this, thanks for fixing this up!

@jborean93 jborean93 merged commit c5f3462 into ansible-collections:main Jun 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants