-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force option to win psrepository copy #599
Add force option to win psrepository copy #599
Conversation
add logic on ps1 file
remove trailing whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, there are two more things we would need to see;
- A changelog fragment documenting this new feature - https://docs.ansible.com/ansible/latest/community/development_process.html#creating-changelog-fragments
- An integration test added to make sure this new feature is idempotent and does what it should be doing
The current integration tests are located https://github.com/ansible-collections/community.windows/tree/main/tests/integration/targets/win_psrepository_copy/tasks. I think adding a new test_force_profiles.yml
and importing it at
- import_tasks: test_include_repo.yml |
test_force_profiles.yml
file would be like test_include_repo.yml but with the force
option and updated expectation at the bottom.
Hi @jborean93 Everything looks fine, but the pipeline keeps failing on "Ansible devel Lint" and I can't figure out why? |
Looks like |
SUMMARY
Adds a
force
option to the win_psrepository_copy module.The current module only had the option to append. This addition also lets you 'set' the repository list identically tot the source
ISSUE TYPE
COMPONENT NAME
win_psrepository_copy
ADDITIONAL INFORMATION