Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force option to win psrepository copy #599

Conversation

tgoetheyn
Copy link
Contributor

SUMMARY

Adds a force option to the win_psrepository_copy module.
The current module only had the option to append. This addition also lets you 'set' the repository list identically tot the source

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_psrepository_copy

ADDITIONAL INFORMATION

Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, there are two more things we would need to see;

The current integration tests are located https://github.com/ansible-collections/community.windows/tree/main/tests/integration/targets/win_psrepository_copy/tasks. I think adding a new test_force_profiles.yml and importing it at

would be ideal. The test_force_profiles.yml file would be like test_include_repo.yml but with the force option and updated expectation at the bottom.

plugins/modules/win_psrepository_copy.py Show resolved Hide resolved
@tgoetheyn
Copy link
Contributor Author

Hi @jborean93
I added the changelog and wrote an integration test.

Everything looks fine, but the pipeline keeps failing on "Ansible devel Lint" and I can't figure out why?

@jborean93
Copy link
Collaborator

Looks like ansible-lint in CI is ignoring our ignore rules file, I'll need to look into that separately so we can skip that check for this PR. Appreciate you working on this.

@jborean93 jborean93 merged commit 18e9139 into ansible-collections:main Jan 15, 2025
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants