Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snc 39092 logging enhancement specific logging server attribute deletion #486

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Snc 39092 logging enhancement specific logging server attribute deletion #486

wants to merge 17 commits into from

Conversation

awhaley-dell
Copy link
Collaborator

SUMMARY

Added functionality to the logging module enabling deletion of a logging server's optional attributes.

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".

  • N/A
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • logging module : DELETE state
OUTPUT
Regression test case deleting attributes without deleting the logging server entirely

logging_delete_specific_parameter_regression.log
Regression_Logging_Delete_Specific_Attribute.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Logging modules regression test

Austin Whaley and others added 7 commits November 12, 2024 18:12
Adding ability to delete a logging server's attribute without removin…
0af70dc 
…g the whole server
Removing unused validate_want function from logging config file
65f940c
Removing outdated message about not deleting attributes and adding at…
5f6dd1d 
…tribute deletion example
Adding severity output to the logging module documentation and adding…
2e62897 
… default values to logging server parameters
@awhaley-dell
Merge branch 'ansible-collections:main' into SNC-39092_logging_enhanc…
6c9e0db 
…ement_specific-logging-server-attribute-deletion
@awhaley-dell
Merge branch 'main' into SNC-39092_logging_enhancement_specific-loggi…
f433a4e 
…ng-server-attribute-deletion
Updating regression test to include deleting a specific attribute and…
6c3fc70 
… overriding a single logging server.
@awhaley-dell awhaley-dell added the enhancement New feature or request label Nov 26, 2024
@awhaley-dell awhaley-dell added this to the v3.1.0 milestone Nov 26, 2024
@awhaley-dell awhaley-dell self-assigned this Nov 26, 2024
@awhaley-dell awhaley-dell marked this pull request as draft November 26, 2024 01:54
Austin Whaley added 8 commits December 4, 2024 19:37
Adding newline to the end of the logging regression tests
77c4922
Adding default value for logging servers severity attribute
79b1847
Adding newline to end of loggings regression playbook
c36e2b7
Adding new delete attributes test case and fixing bug where existing …
bc84646 
…config attributes were missing openconfig-system preface
Adding default values for attributes "severity", "protocol", and "mes…
4f25205 
…sage-type" to reflect the SONIC 4.4.0/4.5.0 behavior.
Fixing pylint/pep8 style issues with whitespaces
483eaf9
Removing explicit default value definitions in argspec and module.
3abbd14 
Adding that breaks delete single remote server functionality for the module.
Don't want to introduce any breaking changes in this push.
Noted the default values in the description instead.
Adding unit test call for deleted_03 in logging.
6df421f 
Made lines between regression tests standard at 1 line.
@awhaley-dell awhaley-dell marked this pull request as ready for review December 5, 2024 17:38
@awhaley-dell
Merge branch 'ansible-collections:main' into SNC-39092_logging_enhanc…
4681cfc 
…ement_specific-logging-server-attribute-deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalabi1 stalabi1 stalabi1 approved these changes

@aida-shumburo aida-shumburo Awaiting requested review from aida-shumburo

@kerry-meyer kerry-meyer Awaiting requested review from kerry-meyer kerry-meyer is a code owner

Assignees

@awhaley-dell awhaley-dell

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@awhaley-dell @stalabi1