Skip to content

Add FBS classifiers resource module #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 17, 2025

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Dec 4, 2024

SUMMARY

I added the FBS classifiers resource module.
Please see model PR.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_fbs_classifiers

OUTPUT

regression-2025-01-16-15-08-12.html.pdf
facts_gathering.log
diff_output.log
check_mode_output.log
ansible_lint_output.txt

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.

@stalabi1 stalabi1 added the new_resource_module This pull request adds a new resource module label Dec 4, 2024
@stalabi1 stalabi1 added this to the v3.1.0 milestone Dec 4, 2024
@stalabi1 stalabi1 requested a review from kerry-meyer as a code owner December 4, 2024 23:40
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure and most details of the proposed code look good. The corresponding test results also look good.

I am requesting a few changes, mostly minor.

I would like to re-check the test results after the changes to verify the requested change in "replaced" state behavior.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All proposed code in the current version of the change set and the corresponding test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 548930d into ansible-collections:main Jan 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants