-
Notifications
You must be signed in to change notification settings - Fork 76
Add FBS classifiers resource module #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FBS classifiers resource module #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure and most details of the proposed code look good. The corresponding test results also look good.
I am requesting a few changes, mostly minor.
I would like to re-check the test results after the changes to verify the requested change in "replaced" state behavior.
plugins/module_utils/network/sonic/config/fbs_classifiers/fbs_classifiers.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/facts/fbs_classifiers/fbs_classifiers.py
Show resolved
Hide resolved
tests/regression/roles/sonic_fbs_classifiers/tasks/cleanup.yaml
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/fbs_classifiers/fbs_classifiers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All proposed code in the current version of the change set and the corresponding test results look good.
Approved.
SUMMARY
I added the FBS classifiers resource module.
Please see model PR.
ISSUE TYPE
COMPONENT NAME
sonic_fbs_classifiers
OUTPUT
regression-2025-01-16-15-08-12.html.pdf
facts_gathering.log
diff_output.log
check_mode_output.log
ansible_lint_output.txt
Checklist: