Add FBS classifiers resource module #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalabi1
added
the
new_resource_module
kerry-meyer
requested changes
Jan 15, 2025
Collaborator
kerry-meyer
left a comment
kerry-meyer
left a comment
There was a problem hiding this comment.
The structure and most details of the proposed code look good. The corresponding test results also look good.
I am requesting a few changes, mostly minor.
I would like to re-check the test results after the changes to verify the requested change in "replaced" state behavior.
plugins/module_utils/network/sonic/config/fbs_classifiers/fbs_classifiers.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/facts/fbs_classifiers/fbs_classifiers.py
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/fbs_classifiers/fbs_classifiers.py
Outdated
Show resolved
Hide resolved
kerry-meyer
approved these changes
Jan 17, 2025
Collaborator
kerry-meyer
left a comment
kerry-meyer
left a comment
There was a problem hiding this comment.
All proposed code in the current version of the change set and the corresponding test results look good.
Approved.
arulkumar9690
pushed a commit
to arulkumar9690/dellemc.enterprise_sonic
that referenced
this pull request
Jun 3, 2025
* Add FBS classifiers resource module * Update overridden state and fix ansible-lint errors * Fix ansible-lint errors and update copyright * Update sonic_fbs_classifiers.py * Address Kerry's private review comments * Add new line * Address Kerry's review comments * Fix unit test error * Fix replace logic * Remove incorrect breaks * Add continues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I added the FBS classifiers resource module.
Please see model PR.
ISSUE TYPE
COMPONENT NAME
sonic_fbs_classifiers
OUTPUT
regression-2025-01-16-15-08-12.html.pdf
facts_gathering.log
diff_output.log
check_mode_output.log
ansible_lint_output.txt
Checklist: