Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ansible-lint errors in playbooks directory #501

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aida-shumburo
Copy link
Collaborator

@aida-shumburo aida-shumburo commented Jan 14, 2025

SUMMARY

This PR is to fix eorrors that are currently providing incorrect examples of playbooks for customers.

ISSUE TYPE
  • Docs Pull Request
OUTPUT
Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran 'ansible-lint playbooks/bgp_l3_fabric' to run ansible-lint on the files within the playbooks/bgp_l3_fabric directory.

@aida-shumburo aida-shumburo changed the title fix ansible-lint errors in playbooks/bgp_l3_fabric and playbooks/comm… fix ansible-lint errors in playbooks directory Jan 14, 2025
@aida-shumburo aida-shumburo marked this pull request as ready for review January 14, 2025 20:14
Copy link
Collaborator

@awhaley-dell awhaley-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes look good except for the removal of the collections module. I have concerns about the module paths that are recommended in place of the simple collections technique.

playbooks/bgp_l3_fabric/clos-fabric.yaml Outdated Show resolved Hide resolved
@aida-shumburo aida-shumburo added the documentation Improvements or additions to documentation label Jan 15, 2025
Copy link
Collaborator

@ArunSaravananBalachandran ArunSaravananBalachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For uniformity, the indentation level used in the playbook 'clos-fabric.yaml' (2 spaces) can be used in the vars and inventory files.

Copy link
Collaborator

@awhaley-dell awhaley-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 1 indentation error that needs to be addressed before approval

playbooks/bgp_l3_fabric/group_vars/leaf.yaml Outdated Show resolved Hide resolved
peer_group:
- name: LEAF
remote_as:
peer_type: external
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
peer_type: external
peer_type: external

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants