-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ansible-lint errors in playbooks directory #501
base: main
Are you sure you want to change the base?
fix ansible-lint errors in playbooks directory #501
Conversation
…on_examples directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes look good except for the removal of the collections module. I have concerns about the module paths that are recommended in place of the simple collections technique.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For uniformity, the indentation level used in the playbook 'clos-fabric.yaml' (2 spaces) can be used in the vars and inventory files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 1 indentation error that needs to be addressed before approval
peer_group: | ||
- name: LEAF | ||
remote_as: | ||
peer_type: external |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peer_type: external | |
peer_type: external |
SUMMARY
This PR is to fix eorrors that are currently providing incorrect examples of playbooks for customers.
ISSUE TYPE
OUTPUT
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration