chore: fix gcp_sql_database integration test #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this and #602 the tests are green (phew). There's a few tests that were disabled due to flakiness, but so far those seems to be API issues rather than problems with the Ansible module. I'm going to try to get those running reliably and update the version(s) of Ansible we're testing against next. |
rileykarson
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MySQL 8.x "utf8" really mean "utf8mb3" and when you request
utf8as thecharset,utf8mb3is what's returned. Thanks to that, instead of being a no-op the "create a database that already exists" test attempts to update the database and fails rather than seeing that the database exists and is in the correct configuration. The fix here is to use a valid character set (utf8mb4is the recommended encoding).