-
Notifications
You must be signed in to change notification settings - Fork 136
Test with ansible-core 2.19 #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #695 +/- ##
=======================================
Coverage 30.29% 30.29%
=======================================
Files 177 177
Lines 19772 19772
Branches 3253 3253
=======================================
Hits 5990 5990
Misses 13774 13774
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm wondering whether the integration tests actually pass, though, since for some reason they have been skipped by this PR... |
I think integration tests are only run on merge https://github.com/ansible-collections/google.cloud/blob/master/.github/workflows/ansible-integration-tests.yml#L3-L6 |
We will put it in our backlog. Since 2.19 is Technical preview currently its not high on our priority scale. We are workign on fixing issues that have been raised, and adding new modules. |
@stevefulme1 What do you mean with ansible-core 2.19 being technical preview? It has been released 10 days ago on PyPI. It's the latest stable ansible-core release. |
ansible-core 2.19 is technical preview for AAP customers. The most recent supported version right now is 2.18 within AAP. |
@stevefulme1 we did re-add google.cloud to Ansible 12 basically last-minute. Ansible 12 is based on ansible-core 2.19. So please make sure ASAP to put this on a high priority. Thanks. |
Fixes #680
SUMMARY
I think it's about time to start testing with ansible-core 2.19.
ISSUE TYPE
COMPONENT NAME
.github/workflows/ansible-integration-tests.yml
.github/workflows/ansible-test.yml
ADDITIONAL INFORMATION
https://forum.ansible.com/t/8609/13