[Sanity] [module_utils/encode] Sanity error failing with 2.18 #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one took more than expected due to intermittent issues while testing |
richp405
approved these changes
Jan 22, 2025
Yes and tbh makes no sense to me bc there other variables with the same definition style and it does not raise any issue. |
rexemin
approved these changes
Jan 22, 2025
Rohitcodes28
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Added encode fix * Added changelogs * Fixed users utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes sanity 2.18 error message:
ERROR: plugins/module_utils/encode.py:440:27: used-before-assignment: Using variable 'dest_f' before assignment
ISSUE TYPE
COMPONENT NAME
module_utils/encode.py
ADDITIONAL INFORMATION