-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate win_iis_virtualdirectory #10
base: main
Are you sure you want to change the base?
Migrate win_iis_virtualdirectory #10
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/index_module.html b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/index_module.html
index 41555e5..5eab251 100644
--- a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/index_module.html
+++ b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/index_module.html
@@ -120,6 +120,8 @@
<section id="microsoft-iis">
<h2>microsoft.iis<a class="headerlink" href="#microsoft-iis" title="Link to this heading"></a></h2>
<ul class="simple">
+<li><p><a class="reference internal" href="microsoft/iis/virtual_directory_module.html#ansible-collections-microsoft-iis-virtual-directory-module"><span class="std std-ref">microsoft.iis.virtual_directory</span></a> – Configures a virtual directory in IIS</p></li>
+<li><p><a class="reference internal" href="microsoft/iis/virtual_directory_info_module.html#ansible-collections-microsoft-iis-virtual-directory-info-module"><span class="std std-ref">microsoft.iis.virtual_directory_info</span></a> – Retrive information on a virtual directory in IIS</p></li>
<li><p><a class="reference internal" href="microsoft/iis/web_app_pool_module.html#ansible-collections-microsoft-iis-web-app-pool-module"><span class="std std-ref">microsoft.iis.web_app_pool</span></a> – Configure IIS Web Application Pools</p></li>
<li><p><a class="reference internal" href="microsoft/iis/web_app_pool_info_module.html#ansible-collections-microsoft-iis-web-app-pool-info-module"><span class="std std-ref">microsoft.iis.web_app_pool_info</span></a> – Get information on IIS Web Application Pools</p></li>
<li><p><a class="reference internal" href="microsoft/iis/web_application_module.html#ansible-collections-microsoft-iis-web-application-module"><span class="std std-ref">microsoft.iis.web_application</span></a> – Configures IIS web applications</p></li>
diff --git a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/microsoft/iis/docsite/guide_migration.html b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/microsoft/iis/docsite/guide_migration.html
index 73cb198..98d8ccb 100644
--- a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/microsoft/iis/docsite/guide_migration.html
+++ b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/microsoft/iis/docsite/guide_migration.html
@@ -21,7 +21,7 @@
<script src="../../../../_static/sphinx_highlight.js?v=dc90522c"></script>
<script src="../../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../../search.html" />
- <link rel="next" title="microsoft.iis.web_app_pool module – Configure IIS Web Application Pools" href="../web_app_pool_module.html" />
+ <link rel="next" title="microsoft.iis.virtual_directory module – Configures a virtual directory in IIS" href="../virtual_directory_module.html" />
<link rel="prev" title="Microsoft.Iis" href="../index.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -156,7 +156,7 @@
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
<a href="../index.html" class="btn btn-neutral float-left" title="Microsoft.Iis" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
- <a href="../web_app_pool_module.html" class="btn btn-neutral float-right" title="microsoft.iis.web_app_pool module – Configure IIS Web Application Pools" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
+ <a href="../virtual_directory_module.html" class="btn btn-neutral float-right" title="microsoft.iis.virtual_directory module – Configures a virtual directory in IIS" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
<hr/>
diff --git a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/microsoft/iis/index.html b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/microsoft/iis/index.html
index b5e0e95..dbeb278 100644
--- a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/microsoft/iis/index.html
+++ b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/microsoft/iis/index.html
@@ -176,6 +176,8 @@
<section id="modules">
<h3>Modules<a class="headerlink" href="#modules" title="Link to this heading"></a></h3>
<ul class="simple">
+<li><p><a class="reference internal" href="virtual_directory_module.html#ansible-collections-microsoft-iis-virtual-directory-module"><span class="std std-ref">virtual_directory module</span></a> – Configures a virtual directory in IIS</p></li>
+<li><p><a class="reference internal" href="virtual_directory_info_module.html#ansible-collections-microsoft-iis-virtual-directory-info-module"><span class="std std-ref">virtual_directory_info module</span></a> – Retrive information on a virtual directory in IIS</p></li>
<li><p><a class="reference internal" href="web_app_pool_module.html#ansible-collections-microsoft-iis-web-app-pool-module"><span class="std std-ref">web_app_pool module</span></a> – Configure IIS Web Application Pools</p></li>
<li><p><a class="reference internal" href="web_app_pool_info_module.html#ansible-collections-microsoft-iis-web-app-pool-info-module"><span class="std std-ref">web_app_pool_info module</span></a> – Get information on IIS Web Application Pools</p></li>
<li><p><a class="reference internal" href="web_application_module.html#ansible-collections-microsoft-iis-web-application-module"><span class="std std-ref">web_application module</span></a> – Configures IIS web applications</p></li>
diff --git a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/microsoft/iis/web_app_pool_module.html b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/microsoft/iis/web_app_pool_module.html
index d51fe37..36f1010 100644
--- a/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/base/collections/microsoft/iis/web_app_pool_module.html
+++ b/home/runner/work/microsoft.iis/microsoft.iis/docsbuild/head/collections/microsoft/iis/web_app_pool_module.html
@@ -23,7 +23,7 @@
<script src="../../../_static/js/theme.js"></script>
<link rel="search" title="Search" href="../../../search.html" />
<link rel="next" title="microsoft.iis.web_app_pool_info module – Get information on IIS Web Application Pools" href="web_app_pool_info_module.html" />
- <link rel="prev" title="Migration guide" href="docsite/guide_migration.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
+ <link rel="prev" title="microsoft.iis.virtual_directory_info module – Retrive information on a virtual directory in IIS" href="virtual_directory_info_module.html" /><!-- extra head elements for Ansible beyond RTD Sphinx Theme -->
@@ -311,7 +311,7 @@ To check whether it is installed, run <code class="code docutils literal notrans
<footer><div class="rst-footer-buttons" role="navigation" aria-label="Footer">
- <a href="docsite/guide_migration.html" class="btn btn-neutral float-left" title="Migration guide" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
+ <a href="virtual_directory_info_module.html" class="btn btn-neutral float-left" title="microsoft.iis.virtual_directory_info module – Retrive information on a virtual directory in IIS" accesskey="p" rel="prev"><span class="fa fa-arrow-circle-left" aria-hidden="true"></span> Previous</a>
<a href="web_app_pool_info_module.html" class="btn btn-neutral float-right" title="microsoft.iis.web_app_pool_info module – Get information on IIS Web Application Pools" accesskey="n" rel="next">Next <span class="fa fa-arrow-circle-right" aria-hidden="true"></span></a>
</div>
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 04s |
f42e525
to
836e9b9
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s |
836e9b9
to
0be08d2
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 2m 52s |
0be08d2
to
d101d50
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 47s |
bbf8434
to
87dbbc5
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 04s |
87dbbc5
to
d16d71b
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 26s |
d16d71b
to
f6552d2
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 23s |
f6552d2
to
d7b8272
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 39s |
d7b8272
to
eeedfbf
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
eeedfbf
to
25ba101
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 09s |
25ba101
to
d60c5c0
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 29s |
d60c5c0
to
b9c4dcf
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 18s |
39c209e
to
6434db0
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 18s |
7cbae50
to
8c92378
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 22s |
8c92378
to
bdd2a0d
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 17s |
bdd2a0d
to
bb47024
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 44s |
tests/integration/targets/virtualdirectory_info/tasks/tests.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/virtualdirectory_info/tasks/tests.yml
Outdated
Show resolved
Hide resolved
bb47024
to
aa9d4a1
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 57s |
* Fix up docs after migration * Fix up sanity errors
* fix up sanity ignores * Bump ansible-windows dep * Fix bad change for win_region
… (#347) * win_iis_virtualdirectory: Add credential support and integration test - Added parameters ('connect_as', 'username', 'password') so that credentials can be set when creating a virtual directory. - Fixed the method of getting virtual directory information when the parameter 'application' is set. - Added integration tests. * Ccreate a changelog fragment * Add version_added parameter to document
fb91bb8
to
0e3c7f8
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 08s |
6881f85
to
e951370
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 09s |
e951370
to
6c39950
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 52s |
|
||
- assert: | ||
that: | ||
- 'vdir_info.directories[0].physical_path == test_physical_path' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not checking username
here so the check isn't doing too much.
that: | ||
- 'result.changed == false' | ||
|
||
- name: Delete virtual directory and use pass through authentication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also have a state: absent
check mode test before this one.
- vdir_info.directories | length == 1 | ||
- 'vdir_info.directories[0].physical_path == test_physical_path' | ||
|
||
- name: Create test application temporary directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need this, remote_tmp_dir
contains a temp directory, we should be re-using that with win_file
if we need a custom subdir This way it'll be cleaned up at the end of the test.
- assert: | ||
that: | ||
- vdir_info.directories | length == 1 | ||
- 'vdir_info.directories[0].physical_path == test_physical_path' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module returns more values, we should be testing them all here.
Creating virtualdirectory (set) module. creating virtualdirectory_info (get) module. Updating Documentation file to ymal format. Creating virtualdirectory_info.ymal Updating tests Adding virtualdirectory_info tests
6c39950
to
610bff1
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 42s |
SUMMARY
Promote the win_iis_virtualdirectory Module from community.windows to microsoft.iis.
ISSUE TYPE
COMPONENT NAME
virtualdirectory.ps1
virtualdirectory_info.ps1
virtualdirectory/aliases
virtualdirectory/defaults/main.yml
virtualdirectory/meta/main.yml
virtualdirectory/tasks/main.yml
virtualdirectory/tasks/tests.yml
ADDITIONAL INFORMATION
Promote the win_iis_virtualdirectory:
Creating virtualdirectory (set) module.
Creating virtualdirectory_info (get) module.
Updating Documentation file to ymal format.
Updating tests