Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate win_iis_webapplication module to new microsoft.iis repository #9

Merged
merged 10 commits into from
Jan 22, 2025
Merged

Migrate win_iis_webapplication module to new microsoft.iis repository #9

merged 10 commits into from
Jan 22, 2025

Conversation

ronger4
Copy link
Contributor

@ronger4 ronger4 commented Dec 25, 2024 •
edited
Loading

SUMMARY
  1. Migrate win_iis_webapplication module to new microsoft.iis repository
  2. Upgrade the module to the Ansible.Basic style module.
  3. Name of the module changed to web_application
  4. Documentation updated
  5. info module will added and called web_application_info
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

win_iis_webapplication

ADDITIONAL INFORMATION

@ronger4 ronger4 marked this pull request as draft December 25, 2024 10:28
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/741b130d96d14eeebdf0c08c315e1a80

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 5m 47s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from bc56e7b to 8f6bf9e Compare December 26, 2024 08:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1b855e48b8144b03b8e727ae9bce0547

✔️ ansible-galaxy-importer SUCCESS in 5m 22s
✔️ build-ansible-collection SUCCESS in 5m 43s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 8f6bf9e to fa6cdff Compare December 26, 2024 08:47
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ccc70d248da04b9f8cf6041c2b2fd58f

✔️ ansible-galaxy-importer SUCCESS in 3m 09s
✔️ build-ansible-collection SUCCESS in 5m 29s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 2a3ce9c to e286373 Compare December 26, 2024 09:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e475318babbe46ae9b01235807bf8726

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 5m 42s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from e286373 to ba5d7e0 Compare December 26, 2024 13:23
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1a60a83ea0c9413ca99a48b1309a1692

✔️ ansible-galaxy-importer SUCCESS in 3m 40s
✔️ build-ansible-collection SUCCESS in 5m 18s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from ba5d7e0 to 4449bb9 Compare December 31, 2024 10:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8e346fb5353b4bcd97e623d885d7066d

✔️ ansible-galaxy-importer SUCCESS in 2m 48s
✔️ build-ansible-collection SUCCESS in 5m 49s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch 3 times, most recently from 3cc9d4a to 7dfe974 Compare January 5, 2025 16:19
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4de864142af7440e90cc40b7fe143bc0

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 5m 15s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 7dfe974 to 68222e3 Compare January 5, 2025 16:31
@ronger4 ronger4 marked this pull request as ready for review January 5, 2025 16:31
@ronger4
Copy link
Contributor Author

ronger4 commented Jan 5, 2025

Ready for review,
Currently the failure in CI is due to the fact this module is dependent on website and webapppool modules and they are still not merged. Using community repo won't work as there is no dependency on this repo.

Another point I would like to address is the fact that :
Running the following won't fail if name that user gave as input is not existing. It will just return an empty application list.
$applications = Get-WebApplication -Name $name

I wonder if I need to make sure there will be a failure or the current functionality is ok.

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 68222e3 to 8c548fb Compare January 5, 2025 16:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dab27f231cf449cb9bdc12aa59d838e0

✔️ ansible-galaxy-importer SUCCESS in 2m 52s
✔️ build-ansible-collection SUCCESS in 5m 24s

shahargolshani pushed a commit to shahargolshani/microsoft.iis that referenced this pull request Jan 9, 2025
@jborean93 @jorgeemir29 @shahargolshani
Add Extra Information for IIS parameters. (ansible-collections#9)
52177e2 
* Add Extra Information for IIS parameters.

hen configuring a website with custom site parameters, for people who are not familiar with PowerShell or IIS, it would be great to add in the documentation some examples to show them how to use these parameters.

* Slight tweaks to the docs

Co-authored-by: Emir Madrueno Peregrina <[email protected]>
jborean93 added a commit that referenced this pull request Jan 9, 2025
@jborean93 @jorgeemir29
Add Extra Information for IIS parameters. (#9)
0732b74 
* Add Extra Information for IIS parameters.

hen configuring a website with custom site parameters, for people who are not familiar with PowerShell or IIS, it would be great to add in the documentation some examples to show them how to use these parameters.

* Slight tweaks to the docs

Co-authored-by: Emir Madrueno Peregrina <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/06e3a621ec32420aa513282c5b4a2478

✔️ ansible-galaxy-importer SUCCESS in 4m 56s
✔️ build-ansible-collection SUCCESS in 5m 39s

jborean93
jborean93 requested changes Jan 14, 2025
View reviewed changes
plugins/modules/web_application.ps1 Outdated Show resolved Hide resolved
plugins/modules/web_application.ps1 Outdated Show resolved Hide resolved
plugins/modules/web_application.ps1 Outdated Show resolved Hide resolved
plugins/modules/web_application.yml Show resolved Hide resolved
plugins/modules/web_application.ps1 Outdated Show resolved Hide resolved
tests/integration/targets/web_application/tasks/tests.yml Show resolved Hide resolved
tests/integration/targets/web_application/tasks/tests.yml Show resolved Hide resolved
tests/integration/targets/web_application/tasks/tests.yml Show resolved Hide resolved
tests/integration/targets/web_application/tasks/tests.yml Outdated Show resolved Hide resolved
tests/integration/targets/web_application_info/tasks/main.yml Outdated Show resolved Hide resolved
jborean93
jborean93 requested changes Jan 14, 2025
View reviewed changes
plugins/modules/web_application.ps1 Outdated Show resolved Hide resolved
@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 95bc3de to 9fbf14c Compare January 15, 2025 14:01
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/08c750628926436fa6049d3e2a6ec921

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 5m 29s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 9fbf14c to bd0440b Compare January 16, 2025 14:22
@ronger4 ronger4 force-pushed the migrate_webappapplication branch from bd0440b to a849b6b Compare January 16, 2025 14:27
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/cd9edd0605804b8c94b893606afa27a8

✔️ ansible-galaxy-importer SUCCESS in 6m 01s
✔️ build-ansible-collection SUCCESS in 5m 24s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from a849b6b to 0f8a98d Compare January 21, 2025 14:57
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/454b83bd2f134a17a4c3ba7fab5fc52a

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 5m 25s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from 0f8a98d to 5ca8967 Compare January 21, 2025 15:34
@ronger4
Copy link
Contributor Author

ronger4 commented Jan 21, 2025

All requests taken care for.
Please don't merge yet,
Need to rebase and fetch the change done by Shahar in order to align with the new utils he added to handle removal better and solves the flaky failures.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/14905e941c4e40e5a08df8a1165913a5

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 5m 19s

ronger4 and others added 9 commits January 22, 2025 12:18
@ronger4
Migrate win_iis_webapplication module to new microsoft.iis repository
9826023
@jborean93 @ronger4
Initial commit
71d2665
@jborean93 @ronger4
Fix up docs after migration (#95)
ca84d76 
* Fix up docs after migration

* Fix up sanity errors
@jborean93 @ronger4
fix up sanity ignores (#97)
6b4db48 
* fix up sanity ignores

* Bump ansible-windows dep

* Fix bad change for win_region
@jborean93 @ronger4
Fix devel sanity checks - ci_complete (#331)
b74f929
@colshine1 @ronger4
docs(win_iis_webapppool.ps1): update to include example on how to set…
fdeb5d0 
… No Managed Code for .Net compatibility (#556)
@jborean93 @ronger4
Upgrade ansible-lint and fix problems (#565)
d94f0b8
@jborean93 @ronger4
Expand connection plugins used in CI (#577)
7f77525 
Expands the testing matrix of the Windows connection plugins used in CI
to cover all the supported connections of Windows.
@AnsibleJosh @ronger4
fixing portion where building app pools with the word value fails. (#…
290cc06 
…587)

* fixing portion where building app pools with the word value fails.

* Create 588-win_iis_webapppool.yaml
@ronger4 ronger4 force-pushed the migrate_webappapplication branch 3 times, most recently from f7e8e79 to 8b093ce Compare January 22, 2025 11:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/88afcbcd2a524036a03c029dcdb75d7f

✔️ ansible-galaxy-importer SUCCESS in 3m 25s
✔️ build-ansible-collection SUCCESS in 5m 38s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch 2 times, most recently from 9a51fce to b6de23e Compare January 22, 2025 12:41
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9515398bbf15454b83ae820f92d87ec6

✔️ ansible-galaxy-importer SUCCESS in 3m 23s
✔️ build-ansible-collection SUCCESS in 5m 49s

@ronger4 ronger4 force-pushed the migrate_webappapplication branch from b6de23e to 32cc8c3 Compare January 22, 2025 15:00
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/481f1343dde44df5a855a6fb6e631513

✔️ ansible-galaxy-importer SUCCESS in 2m 42s
✔️ build-ansible-collection SUCCESS in 5m 42s

@ronger4
Copy link
Contributor Author

ronger4 commented Jan 22, 2025

Hi @jborean93,
PR should be ready for review.
I integrated Shahar's changes with the setup_iis util too.
Thanks.

jborean93
jborean93 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for sticking through with my reviews!

tests/integration/targets/web_application/tasks/tests.yml Show resolved Hide resolved
@jborean93 jborean93 merged commit c67e9a9 into ansible-collections:main Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronger4 @jborean93 @colshine1 @AnsibleJosh