Skip to content

Execution environment test builds #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Apr 23, 2025

Addresses #16

Opening as a draft to start a conversation and get some advice on how to proceed.

  • At the moment I've been using an arg parser to pass things like the path and collection namespace and name. This has been a convenient way to test things and work through the logic. I plan to modify things and get this better integrated with the rest of the project but wanted to open a PR and work through all that collaboratively.
  • Need to add docstrings and type hints.
  • Need to add actual tests for ee builds. Should I port over the contents of https://github.com/ansible-collections/community.docker/tree/main/tests/ee ?

@oraNod oraNod requested review from felixfontein and gotmax23 April 23, 2025 15:35
@oraNod oraNod force-pushed the issue-16/ee-test-builds branch 2 times, most recently from d5fb00b to 31d022b Compare May 15, 2025 09:27
@oraNod
Copy link
Contributor Author

oraNod commented May 29, 2025

@felixfontein Hey, thanks for #83 that looks like it simplifies things. I can just import with this:

from .collection import (
    build_collection,
)

Is that correct? I'm just wondering though, will that result in the collection being built for each session? On the one hand that makes sense if you're running individual test sessions (not sure if that's even possible). But if you're running all test sessions at once, does that mean the collection gets built multiple times?

@felixfontein
Copy link
Collaborator

Is that correct?

Yes.

I'm just wondering though, will that result in the collection being built for each session?

Yes.

On the one hand that makes sense if you're running individual test sessions (not sure if that's even possible). But if you're running all test sessions at once, does that mean the collection gets built multiple times?

That's true, but it could also happen in different contexts (i.e. with different ansible-core versions or branches). Also building is usually the fastest part of all tests involving builds, so I think it's ok. (At least for now; it can always be improved later on.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants