fixing some mismatched tags and tasks in 5.6.1.x #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
numericillustration
force-pushed
the
devel
branch
from
428fe8b
to
2d5587a
Compare
|
Thank you for the PR, good catch on the entries, i have noticed hoever that the GPG signature is missing from your commit, if you could please add this as it is required, we are then very happy to accept this. Many thanks uk-bolly |
numericillustration
force-pushed
the
devel
branch
from
2d5587a
to
e812fd3
Compare
|
@uk-bolly ok great, I've gone through the GH docs on doing this and have both signed the commit as well as added my key to gh so it verifies now. Happy to contribute. |
Signed-off-by: Michael Hicks <[email protected]>
numericillustration
force-pushed
the
devel
branch
from
e812fd3
to
1c7990c
Compare
|
apologies, had to amend and also sign off again happy to collaborate and improve this body of work. |
uk-bolly
approved these changes
Feb 19, 2024
|
Great work thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
task 5.6.1.1 was mistagged as 5.5.11
task 5.6.1.5 was mistagged as 5.5.1.5
Issue Fixes:
#149
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A