Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file path to /etc/group #94

Closed
wants to merge 1 commit into from

Conversation

igorsobot
Copy link

@igorsobot igorsobot commented Sep 7, 2023

Overall Review of Changes:
Bug fix for section 6_1_3 where wrong file permissions are checked agaist.

Issue Fixes:
Bug fix where wrong file was used, /etc/group- instead of /etc/group

How has this been tested?:
Tested on server with operating system AlmaLinux release 9.1 (Lime Lynx), by running instructions for ansible playbook.

Signed-off-by: Igor Šobot <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

@igorsobot
Copy link
Author

igorsobot commented Sep 11, 2023

Looks like we are having false positive checks, because it fails on non relevant step 1.3.1:

fatal: [rhel9]: FAILED! => {"changed": false, "msg": "Failed to download metadata for repo 'appstream': repomd.xml GPG signature verification error: Bad GPG signature", "rc": 1, "results": []}```

@igorsobot igorsobot closed this Sep 11, 2023
@igorsobot igorsobot reopened this Sep 11, 2023
@uk-bolly
Copy link
Member

hi @igorsobot

Thank you for raising the PR. I have fix already in an open PR for this issue, its seems that alma have changed their repo_gpgchecking inline to act as Redhat does.
Once that merge has taken place if you then update yours all should be good.
WIll chase the PR again and let you know.

Thank you again for your time and watching the PR status.

uk-bolly

@igorsobot igorsobot closed this Sep 18, 2023
@igorsobot igorsobot reopened this Sep 18, 2023
@igorsobot igorsobot closed this Sep 28, 2023
@igorsobot igorsobot reopened this Sep 28, 2023
@uk-bolly
Copy link
Member

hi @igorsobot

Thank you for reopening this issue. I can see that the issue is now resolved. Although i have noted not added to the changelog (i will get this resolved).
The path appears to be correct on the latest devel version? Please let me know if this is not working as expected?

many thanks

uk-bolly

@igorsobot
Copy link
Author

igorsobot commented Sep 29, 2023

hi @igorsobot

Thank you for reopening this issue. I can see that the issue is now resolved. Although i have noted not added to the changelog (i will get this resolved). The path appears to be correct on the latest devel version? Please let me know if this is not working as expected?

many thanks

uk-bolly

Hi @uk-bolly , since I am not repo owner, I do not understand problem in playbook-test

TASK [Gathering Facts] ********************************************************* fatal: [rhel9]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: ssh: connect to host 18.234.79.58 port 22: Operation timed out", "unreachable": true}

@igorsobot igorsobot closed this Oct 2, 2023
@igorsobot igorsobot reopened this Oct 2, 2023
@igorsobot
Copy link
Author

igorsobot commented Oct 2, 2023

Looks like we are having flaky playbook.
We got error in playbook-test at step when we call arillso/action.playbook@master

ERROR! Unexpected Exception, this is probably a bug: '/api/v3/plugin/ansible/content/published/collections/index/community/general/versions/'

@igorsobot igorsobot closed this Oct 2, 2023
@igorsobot igorsobot reopened this Oct 2, 2023
@uk-bolly
Copy link
Member

Looks like we are having flaky playbook. We got error in playbook-test at step when we call arillso/action.playbook@master

ERROR! Unexpected Exception, this is probably a bug: '/api/v3/plugin/ansible/content/published/collections/index/community/general/versions/'

hi @igorsobot

The original PR is incorporated and resolved. What has also occurred in the meantime is that ansible-galaxy changed and is no longer working with older versions which we test with as part of the pipeline (we run newer locally aswell). This caused the issue and this has now been resolved with the PR into devel today.

hope that helps.

I will close this PR. If you are still seeing problems please open a new issue so we are at a clean starting point.

Many thanks

Mark

@uk-bolly uk-bolly closed this Oct 10, 2023
@igorsobot
Copy link
Author

@uk-bolly Could you give link to "original PR" since I believe this PR was original for one line fix?

You have to agree even though this is trivial change, it took my time and change is not contributed by me because 3rd party problem not even related to code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants