-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file path to /etc/group #94
Conversation
Signed-off-by: Igor Šobot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
Looks like we are having false positive checks, because it fails on non relevant step 1.3.1:
|
hi @igorsobot Thank you for raising the PR. I have fix already in an open PR for this issue, its seems that alma have changed their repo_gpgchecking inline to act as Redhat does. Thank you again for your time and watching the PR status. uk-bolly |
hi @igorsobot Thank you for reopening this issue. I can see that the issue is now resolved. Although i have noted not added to the changelog (i will get this resolved). many thanks uk-bolly |
Hi @uk-bolly , since I am not repo owner, I do not understand problem in playbook-test
|
Looks like we are having flaky playbook.
|
hi @igorsobot The original PR is incorporated and resolved. What has also occurred in the meantime is that ansible-galaxy changed and is no longer working with older versions which we test with as part of the pipeline (we run newer locally aswell). This caused the issue and this has now been resolved with the PR into devel today. hope that helps. I will close this PR. If you are still seeing problems please open a new issue so we are at a clean starting point. Many thanks Mark |
@uk-bolly Could you give link to "original PR" since I believe this PR was original for one line fix? You have to agree even though this is trivial change, it took my time and change is not contributed by me because 3rd party problem not even related to code change. |
Overall Review of Changes:
Bug fix for section 6_1_3 where wrong file permissions are checked agaist.
Issue Fixes:
Bug fix where wrong file was used, /etc/group- instead of /etc/group
How has this been tested?:
Tested on server with operating system AlmaLinux release 9.1 (Lime Lynx), by running instructions for ansible playbook.