Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve several bugs #4

Closed

Conversation

PoundsOfFlesh
Copy link

Overall Review of Changes:
I discovered several issues while testing on RHEL 9.3. The commits describe what I fixed.

Issue Fixes:
N/A

Enhancements:
N/A

How has this been tested?:
I tested by installing a RHEL 9.3 virtual machine and running the playbook.

@fallenpixel
Copy link

I'm not affiliated with the project at all. I'd suggest you take a look at the contributing guide included in the repository. It discusses the requirements for the repository. Most importantly, your commits must be signed and must have a git signoff. This is likely not going to go anywhere until those requirements are met.

@uk-bolly uk-bolly changed the base branch from main to devel April 18, 2024 15:36
@uk-bolly
Copy link
Member

hi @PoundsOfFlesh

Thank you for taking find, feedback issues and raise the subsequent PR. Unfortunely a couple of issues have arisen.
We are missing the both the sign-off-by and the gog signing of every commit in the PR.
It was also trying to push directly into the main branch. I have changed this to devel but this is not allowing me to rerun with the new setting.
Could i possibly ask if you could cancel this PR and address the issues listed so we can get this pulled?

many thanks

uk-bolly

@uk-bolly uk-bolly self-assigned this Apr 18, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 342 is the pink background file always there?

uk-bolly added a commit that referenced this pull request Apr 18, 2024
Signed-off-by: Mark Bolwell <[email protected]>
uk-bolly added a commit that referenced this pull request Apr 18, 2024
Signed-off-by: Mark Bolwell <[email protected]>
uk-bolly added a commit that referenced this pull request Apr 18, 2024
Signed-off-by: Mark Bolwell <[email protected]>
@PoundsOfFlesh
Copy link
Author

I'm canceling this PR as requested until I figure out how to submit one properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants