Loop over each task. import->includes #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Lehmann <[email protected]>
|
hi @fallenpixel Thank you for taking the time to raise this PR, unfortunetly it was trying to push directly to the main branch rather than devel. This has been solved in the repository but we are not able to run a new workflow on these settings. many thanks uk-bolly |
|
I can get a PR in to devel shortly. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Loop over each task in this block, that way item is defined. Correct the boolean logic for warning/logging for interfaces. Warnings should be issued if an interface in ansible_facts.interfaces is allowed in promiscuous mode.
Issue Fixes:
Please list (using linking) any open issues this PR addresses
#1
Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?:
Tested on fresh install of RHEL 9.3 via the network boot iso.