rule 1.5.4 moved when in package list to service stop #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dderemiah Great catch, although it would be better on the bottom two controls allowing the top to always be added. If you could change that happy to accept the PR. many thanks uk-bolly |
Signed-off-by: Dan D <[email protected]>
|
It is ready for review and merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Moved when in packages line to where it makes sense
Issue Fixes:
This control fails on service stop when package is not installed. Moved when in packages to where it makes sense.
Enhancements:
n/a
How has this been tested?:
tested locally